Skip to content

Fix translated pricing links, directory attributes, and Divi search routes - #18

Open
RabbiIslamRony wants to merge 2 commits into
mainfrom
fix/wpml-translated-plan-links-directory-attributes
Open

RabbiIslamRony wants to merge 2 commits into
mainfrom
fix/wpml-translated-plan-links-directory-attributes

Conversation

@RabbiIslamRony

@RabbiIslamRony RabbiIslamRony commented Sep 20, 2026

Copy link
Copy Markdown
Member

Ticket

Description

  • Resolve Directorist's Add Listing page through WPML before returning pricing-plan action URLs.
  • Preserve existing plan, listing_type, and other query arguments when switching to the translated Add Listing page.
  • Normalize nested directory attributes and term objects before converting directory IDs, preventing Array to string conversion warnings in the WPML admin flow.
  • Keep the Divi Homepage Search form on the translated Directorist Search Result route for non-default languages.
  • Leave the default-language Divi search route unchanged.
  • Add focused regression coverage and prepare the 2.2.4 version/changelog metadata.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change

How has this been tested?

  • Ran PHP syntax checks across app, helper, and tests.
  • Ran every repository tests/*_Test.php regression script successfully.
  • Added a permalink regression test covering the translated Add Listing path and preservation of Directorist's plan and listing_type query arguments.
  • Added nested-array, term-object, and empty nested directory ID regression assertions.
  • Added Divi route assertions covering a translated English result page and the unchanged Spanish default-language route.
  • Ran git diff --check successfully.
  • Verified the combined Divi + WPML behavior resolves the English target to https://esteponeros.com/en/estepona-directory/estepona-businesses/?directorist_home_search=1.

PHP 8.5 reports the repository's existing Reflection::setAccessible() deprecation notices in several test files; all test scripts still pass.

Screenshots

Pricing-plan continuation URL

Divi Homepage Search translated route

Before: English search loses its language route After: English search keeps the translated Directorist route
Before - English Divi homepage search redirects to the default-language homepage After - English Divi homepage search resolves to the translated Directorist results page

Related work

Checklist

  • My code is tested
  • I've included necessary tests
  • I've included developer/release documentation where applicable
  • I've added proper labels to this pull request

@RabbiIslamRony RabbiIslamRony changed the title Fix translated pricing links and nested directory attributes Fix translated pricing links, directory attributes, and Divi search routes Sep 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant