Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
Description
Category-based conditional fields on the add-listing form did not react when a theme rendered an earlier category search dropdown. The conditional-value resolver used a combined selector followed by
.first(), so document order could make it read the theme search field instead of the add-listing category field.The resolver now explicitly prioritizes the canonical add-listing category select and falls back to the search-form category select only when the canonical field is absent. This keeps search-form support while ensuring add-listing conditions evaluate the category the user actually selected. The generated add-listing bundle is rebuilt from the source change.
How to reproduce the issue or test the changes:
Local verification:
assets/src/js/global/add-listing.jscompleted successfully.git diff --checkVerification screenshot:
Notes:
Any linked issues
Checklist