fix: correct popular category membership and zero-coordinate directions - #3020
Merged
Armanul46 merged 1 commit intoSep 14, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Description
Fixes two regressions found while reviewing #3018:
How to test
_directory_typevalues[3],["3"], and[1000,1001,1002,1003], without directory marker metadata. Select directory 3: only the first two should appear. Set the popular-category limit to verify filtering happens before limiting.0, longitude32.5, an empty address, and directions enabled. Get Directions should point to0,32.5. Also check zero longitude, both zeros, address fallback, and directions disabled.wp eval-file wp-content/plugins/directorist/tests/wp-cli/popular-categories-map-directions.php. The test creates and cleans up its fixtures.Validation
--warning-severity=0. SearchForm has the same 133 pre-existing warnings before and after; no errors.Related: #3018
Before - https://prnt.sc/mF7i36DOOw0X
After - https://prnt.sc/LsTe1jqTEcRB
Checklist
GitHub check status
The current PHPCS Action failed at checkout, before PHPCS ran: the base repository's
pull_request_targetworkflow refuses to check out fork code in its privileged context. See failed checkout. Local PHPCS verification above passed; GitHub PHPCS has not executed for this head.