Skip to content

fix: correct advanced search filter labels and reset display - #3022

Open
RabbiIslamRony wants to merge 2 commits into
sovware:developmentfrom
RabbiIslamRony:codex/fix-3322-search-filter-ui
Open

RabbiIslamRony wants to merge 2 commits into
sovware:developmentfrom
RabbiIslamRony:codex/fix-3322-search-filter-ui

Conversation

@RabbiIslamRony

@RabbiIslamRony RabbiIslamRony commented Sep 15, 2026

Copy link
Copy Markdown
Member

PR Type

  • Bugfix
  • Security fix
  • Improvement
  • New Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Text changes
  • Other... Please describe:

Description

Advanced search filters hide configured select labels, long radio/checkbox labels overlap the following fields on narrow screens, and Reset Filters leaves radio selection text visible after clearing the actual inputs.

This change keeps advanced select labels visible above their placeholders, lets modal dropdown labels grow and wrap with space for their controls, and clears radio selection text alongside the existing checkbox summary cleanup. Includes rebuilt public CSS, RTL CSS, and the search-form bundle.

How to reproduce / test

  1. Configure advanced Category/Location fields with labels different from their placeholders, three custom radio fields, and two custom checkbox fields. Use a long label such as PERIODO DI VISIBILITA DELLA SPONSORIZZAZIONE.
  2. Render the native Directorist search shortcode and open More Filters. Confirm the configured select labels remain visible above the placeholders.
  3. Select one option in each radio field, close the dropdowns, and click Reset Filters. All three inputs and their displayed selection text must clear; directory context must remain intact.
  4. Select a category and two checkbox options, then reset. Confirm the category, checked inputs, selected count, and prefix clear.
  5. Check at 320, 360, 768, and 1280px. Long labels must stay within their own rows; fields below the visible modal area remain reachable by scrolling.

Validation

  • Reproduced all three defects against trunk at a3aa54a9a5 with a request-only WordPress fixture and the real native renderer.
  • Chromium: three-radio reset, category + checkbox reset, directory-context preservation, and label bounds at all four widths passed after the fix. No page JavaScript errors in those flows.
  • Combined Core + Divi Homepage Search checks passed. The Divi-only disabled Reset button has its own PR.
  • Targeted production Webpack build passed for public search-form JS and public CSS/RTL CSS (bundle-size warnings only).
  • git diff --check passed. Whole-file Prettier checks also warn on the unmodified base files; unrelated formatting is preserved. No PHP changes.
  • This is local component/runtime validation, not deployment or a full clone of the customer site.

Before / After screenshots

Captured from the same local fixture. Files are supplied separately for manual upload into this PR.

Scenario Before After
Mobile labels and reset result https://prnt.sc/a4uJS3xkQiLb https://prnt.sc/_XomLGdu-tUf
Desktop selected radio fields https://prnt.sc/O3lrevZ3lymx https://prnt.sc/KMVRfXISRmqa

Any linked issues

Checklist

@RabbiIslamRony
RabbiIslamRony changed the base branch from trunk to development September 15, 2026 04:55
@Armanul46 Armanul46 added this to the v8.9.6 milestone Sep 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants