Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
Description
The frontend Order History table can remain in English even when matching Directorist JavaScript translations are available. Its script does not register a translation domain, the Orders title is hardcoded, and several table strings are missing from the POT template. The shared DataViews empty message also uses the WordPress default domain instead of the plugin catalog.
Register the dashboard script translations, localize Orders, reuse the existing Order ID string, and add the missing catalog entries with built-JavaScript references so translation tools can generate the correct JSON catalog. After the order dashboard container is found, register an
i18n.gettext_defaultfallback for an untranslated No results message. It reads the Directorist translation while preserving an existing WordPress translation and leaving other strings and domains unchanged. Rebuild the tracked dashboard bundle and asset manifest.How to reproduce the issue or test the changes:
Local verification:
php -l includes/asset-loader/init.phpandnode --check assets/build/js/react/frontend/listing-owner-dashboard.jspassed.git diff --checkpassed.Notes:
Any linked issues
Checklist