Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Description
Pending reviews were rendered with a low-emphasis inline moderation message, so users could easily miss the successful submission state. The existing alert close handler also waited for the window
loadevent and only bound to buttons present at that moment, which could leave the close icon unresponsive.This PR:
How to reproduce
Local verification
php -l includes/review/class-review-walker.php.npm run build-legacyandgit diff --check.Screenshot
Notes if any
PHPCSHelper.php:98. PHP syntax validation passed.Any linked issues
Checklist