Conversation
glimchb
force-pushed
the
mergable-changes-preview
branch
from
July 30, 2026 11:54
4dca015 to
755b472
Compare
glimchb
force-pushed
the
mergable-changes-preview
branch
from
July 30, 2026 12:22
755b472 to
17a2ea4
Compare
glimchb
force-pushed
the
mergable-changes-preview
branch
2 times, most recently
from
July 30, 2026 14:11
54097a2 to
cf4d1f4
Compare
glimchb
changed the title
glimchb
force-pushed
the
mergable-changes-preview
branch
2 times, most recently
from
July 30, 2026 15:34
0bd3900 to
004290a
Compare
glimchb
marked this pull request as draft
August 10, 2026 14:24
glimchb
force-pushed
the
mergable-changes-preview
branch
from
September 8, 2026 13:15
004290a to
615708e
Compare
Contributor
Author
rebased |
Add a GitHub Actions workflow (.github/workflows/mergable-changes-preview.yml) triggered on PRs changing mergable_changes.py or template.html and on workflow_dispatch. It renders the page with live Gerrit data, uploads the output as an artifact, and posts the HTML as a PR comment. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com> Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
glimchb
force-pushed
the
mergable-changes-preview
branch
from
September 8, 2026 13:17
615708e to
56953ce
Compare
glimchb
marked this pull request as ready for review
September 8, 2026 13:17
karlatec
suggested changes
Sep 9, 2026
| uses: actions/checkout@v7 | ||
|
|
||
| - name: Install Python dependencies | ||
| run: pip install requests pygerrit2 prettytable jinja2 |
Contributor
There was a problem hiding this comment.
Nit - copy pasta from mergable_changes/Dockerfile. Let's move it to requirements.txt if used in more than one place?
|
|
||
| - name: Post preview comment on PR | ||
| if: false | ||
| #if: github.event_name == 'pull_request' |
Contributor
There was a problem hiding this comment.
Feels like if: false should be deleted and pull_request re-enabled?
Also - shouldn't this be run only in case previous steps have succeeded? (i.e. html file was actually generated)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a GitHub Actions workflow (.github/workflows/mergable-changes-preview.yml)
triggered on PRs changing mergable_changes.py or template.html and on
workflow_dispatch. It renders the page with live Gerrit data, uploads
the output as an artifact, and posts the HTML as a PR comment.
Generated with Devin