Skip to content

ci: add SPDK/OCF test workflow - #233

Open
robertbaldyga wants to merge 2 commits into
spdk:mainfrom
robertbaldyga:unvertical-ocf-workflow
Open

robertbaldyga wants to merge 2 commits into
spdk:mainfrom
robertbaldyga:unvertical-ocf-workflow

Conversation

@robertbaldyga

Copy link
Copy Markdown

Add a workflow which runs the SPDK OCF test suite on an Unvertical self-hosted runner, and hook it into the Gerrit webhook handler. The job only fires for patch sets touching module/bdev/ocf or test/ocf.

We do not call autorun.sh, as we want to have control over test scope selection (per-PR vs nightly/weekly). The workflow does it best to be as compatible with autorun.sh as possible.

The workflow needs the OCF test rework, which is still in review. Until it gets merged, there is a check that fails the workflow for all the patchsets other than the rework.

Comment thread .github/workflows/unvertical-ocf.yml Outdated
contains(inputs.changed_files, '"module/bdev/ocf/') ||
contains(inputs.changed_files, '"test/ocf/')
runs-on: [self-hosted, unvertical-ocf-vm]
timeout-minutes: 90

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop it down to 60 like in spdk-common-test.yml? 60 is already very generous, I don't think we'd like to wait more than that.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow is meant to be used for both per-patch tests (ocf.sh), which should easily fit under 30 minutes, and weekly tests (ocf_all.sh), which already take well over 60 minutes. I'll add parametrization depending on the script used.

EOF
./autobuild.sh ../ocf.conf

- name: Allocate hugepages

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy-paste from spdk-common-tests.yml. Consider moving the script into a file under .github/scripts and running with run: .github/scripts/allocate-hugepages.sh

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@karlatec

karlatec commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

PR is in a failing state:

  • pkdgep/debian11 - unrelated
  • valgrind reporting possible leaks in unit tests
  • merge_outputs failing because of ERROR: cannot read /home/runner/work/spdk-ci/spdk-ci/spdk/dpdk/build/include/rte_ring_rts.h. Is the file still somewhere in review? Or is it auto-generated somewhere, and some flags are missing to generate it?

@karlatec karlatec left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to click "Request changes".

Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
Add a workflow which runs the SPDK OCF test suite on an Unvertical
self-hosted runner, and hook it into the Gerrit webhook handler.
The job only fires for patch sets touching module/bdev/ocf or test/ocf.

We do not call autorun.sh, as we want to have control over test scope
selection (per-PR vs nightly/weekly). The workflow does it best to be
as compatible with autorun.sh as possible.

The workflow needs the OCF test rework, which is still in review.
Until it gets merged, there is a check that fails the workflow for all
the patchsets other than the rework.

Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants