Currently our CI pipeline has a linting step that can never fail:
|
run: | |
|
# TODO: Once most errors are fixed remove "set +e" to not ignore errors |
|
set +e |
|
npx eslint --fix --color `echo "${{steps.changed.outputs.changed}}" | tr " " "\n"` |
|
set -e |
This is problematic because most of the time, we do not check the logs of passing CI pipelines. While attempting to fix #8490, I discovered that eslint has been failing to run due to dependency errors for some time, as shown by these logs:
@melton-jason also confirmed that eslint has been failing locally for "A bit over a year or so." Which gives us an estimate for how long this has been happening in our CI pipeline as well.
Since eslint has been failing, but our CI has been reporting it as passing, we have not actually been linting our front-end code.
Currently our CI pipeline has a linting step that can never fail:
specify7/.github/workflows/test.yml
Lines 277 to 281 in 7cf79dc
This is problematic because most of the time, we do not check the logs of passing CI pipelines. While attempting to fix #8490, I discovered that eslint has been failing to run due to dependency errors for some time, as shown by these logs:
@melton-jason also confirmed that eslint has been failing locally for "A bit over a year or so." Which gives us an estimate for how long this has been happening in our CI pipeline as well.
Since eslint has been failing, but our CI has been reporting it as passing, we have not actually been linting our front-end code.