Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
db74532
[test]: create loan by choosing recordset
rijulpoudel Sep 28, 2026
7cbc8db
[test]: create loan by entering cat number
rijulpoudel Sep 28, 2026
a3f76e7
[test]: create loan without preparations
rijulpoudel Sep 29, 2026
4126c10
[test]: fill loan number and dates
rijulpoudel Sep 29, 2026
433da86
[test]: add existing agent to loan
rijulpoudel Sep 29, 2026
db19f74
[test]: create new agent for loan
rijulpoudel Sep 29, 2026
831cd74
[test]: add shipment and fill all fields
rijulpoudel Sep 29, 2026
9c751c0
[test]: add existing shipped by agent to shipment
rijulpoudel Sep 29, 2026
4fbada0
[test]: create new shipped by agent for shipment
rijulpoudel Sep 29, 2026
35fe8c4
[test]: add existing shipped to agent to shipment
rijulpoudel Sep 29, 2026
f9fb85e
[test]: create new shipped to agent for shipment
rijulpoudel Sep 29, 2026
dd4fec6
[test]: add multiple loan agents preps and shipments
rijulpoudel Sep 29, 2026
6c2c4b8
[test]: fill remaining loan fields
rijulpoudel Sep 29, 2026
f3acd60
[test]: save newly created loan
rijulpoudel Sep 29, 2026
cf1095a
[test]: check collection object is loaned
rijulpoudel Sep 29, 2026
ea7a4a6
[test]: add attachment to loan
rijulpoudel Sep 29, 2026
b93eb69
[test]: delete attachment from loan
rijulpoudel Sep 29, 2026
ef4b50f
[test]: verify loan preparations are not carried over when cloning
rijulpoudel Sep 29, 2026
69e04f3
[test]: verify collection objects are not loaned after deleting loan
rijulpoudel Sep 29, 2026
19069d4
[test]: prep availability with unknown and prepless catalog numbers
rijulpoudel Sep 29, 2026
4d6ab31
Merge branch 'main' into issue-8588
CarolineDenis Sep 30, 2026
05004ef
Lint code with ESLint and Prettier
CarolineDenis Sep 30, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -461,6 +461,12 @@ def test_clone_accession(self):
def test_clone_loan(self):
original = self.loans[0]

self._create_prep_type()
original.loanpreparations.create(
discipline=self.discipline,
preparation=self._create_prep(self.collectionobjects[0], None),
)

clone = self._clone_resource(
'loan',
{
Expand All @@ -475,6 +481,8 @@ def test_clone_loan(self):
self.assertEqual(clone.discipline_id, original.discipline_id)
self.assertEqual(clone.remarks, original.remarks)
self.assertNotEqual(clone.loannumber, original.loannumber)
self.assertEqual(original.loanpreparations.count(), 1)
self.assertEqual(clone.loanpreparations.count(), 0)

original.refresh_from_db()
self.assertEqual(original.loannumber, 'Test loan')
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -420,7 +420,22 @@ def test_delete_accession_created_in_previous_version(self):
)

def test_delete_loan_created_in_previous_version(self):
self._create_prep_type()

loan = self.loans[0]

first_prep = self._create_prep(self.collectionobjects[0], None)
second_prep = self._create_prep(self.collectionobjects[1], None)

loan.loanpreparations.create(
discipline=self.discipline,
preparation=first_prep,
)
loan.loanpreparations.create(
discipline=self.discipline,
preparation=second_prep,
)

object_id = loan.id

loan.delete()
Expand All @@ -429,6 +444,22 @@ def test_delete_loan_created_in_previous_version(self):
models.Loan.objects.filter(id=object_id).count(),
0,
)
self.assertEqual(
models.Loanpreparation.objects.filter(loan_id=object_id).count(),
0,
)

first_prep.refresh_from_db()
second_prep.refresh_from_db()

self.assertEqual(
first_prep.loanpreparations.count(),
0,
)
self.assertEqual(
second_prep.loanpreparations.count(),
0,
)

models.Loan.objects.create(
loannumber='Test loan',
Expand Down
Loading
Loading