feat(fonts): embed Francois One font - #8601
grantfitzsimmons wants to merge 1 commit into
Conversation
source it locally instead!
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (3)
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review. 📝 WalkthroughWalkthroughThe frontend now loads Francois One from local font files instead of Google Fonts. The change adds font-face declarations for Vietnamese, Latin Extended, and Latin ranges, plus the font’s SIL Open Font License. ChangesLocal font loading
Priority: ⬇️ Low Change: Feature · Severity of issue fixed: Low Merge Risk: ⚪ Minimal · up to The local font loads for the stated table labels and inspected accented text. No material merge-blocking issue is established. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (5 passed)
Full details: Testing InstructionsExplanation The testing instruction covers the visual table-icon result, and the examples ( Resolution Replace the single instruction with steps that: (1) open a page that renders autogenerated table icons and verify
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Fixes #8598
This PR just removes the external Google Fonts request for Francois One. I just added Francois One WOFF2 font assets and the stylesheet. I've included the SIL Open Font License as requested when redistributing. This is important for self-hosted users without public internet access (and for anyone who does not want to phone home to Google).
This one is pretty simple. No need to wait on Google's servers. 😄
Testing instructions
CO,Loc,Agt) show the correct font! Compare againstv7Summary by CodeRabbit