Fix Allow any valid user access to public Dataset through SDK - #335
Open
mjcurran wants to merge 6 commits into
Open
Fix Allow any valid user access to public Dataset through SDK#335mjcurran wants to merge 6 commits into
mjcurran wants to merge 6 commits into
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 199e050. Configure here.
lucaspar
approved these changes
Aug 21, 2026
lucaspar
left a comment
Member
There was a problem hiding this comment.
Thanks. It'd be good to add some regression tests to make sure this keeps working in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

SFDS-320
Fix permission issues trying to access assets of public datasets
Note
High Risk
Widens authorization: any logged-in user can view/download assets on public datasets and captures. Incomplete coverage of deprecated FK query paths could also leave access inconsistent.
Overview
Authenticated users now get viewer access to public datasets and captures (and their nested files/captures) without an explicit share, so SDK downloads of public dataset assets work.
UserSharePermission.get_user_permission_levelfalls back toPermissionLevel.VIEWERwhen the item is public and not deleted. Capture/file access helpers and the accessible-files/captures querysets treatis_publiclike ownership or a share on M2M relationships (deprecated FK paths are unchanged).Reviewed by Cursor Bugbot for commit ea7aaf7. Bugbot is set up for automated code reviews on this repo. Configure here.