Repository navigation
Fix rolling back item updates - #624
Merged
Merged
Conversation
This fixes a bug where restoring an item that has been updated in such a way that a field storing an external reference (such as parameter_value_list_id in parameter definition) has changed would result in a Traceback. The Traceback resulted when the item would be compared to its backup in MappedItemBase._strip_equal_fields() and all fields would be incorrectly declared as equal. Re spine-tools/Spine-Toolbox#3335
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #624 +/- ##
=======================================
Coverage 86.15% 86.15%
=======================================
Files 83 83
Lines 11475 11475
Branches 1636 1636
=======================================
Hits 9886 9886
Misses 1238 1238
Partials 351 351 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where restoring updated items would sometimes cause a Traceback.
Fixes spine-tools/Spine-Toolbox#3335
Checklist before merging