Break the v2 manifest across modules - #3692
Merged
Merged
Conversation
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
lann
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My super smart sports watch informs me that I have now spent the equivalent of three years of my life searching around the
v2.rsmanifest file trying to find the type / enum case / whatever the heck it is I want. This is in some measure down to greatly enlarged doc comments that we did for JSON schema, which are good and splendid but mean you can only have like 2 declarations on screen at a time.I propose breaking the file up, and as a sighting shot I've done it by top-level section, with the exception of a couple of things that are used across sections. So you end up with something like this:
which to me feels like it will be easier to locate "oh that's where the component manifest goes and now there are only like three things in there." Although maybe having all the files collapsed under the v2 folder will drive me to even greater heights of navigation rage, who knows. And
component.rsanddependency.rsare still 350 lines each which is a bit gross (curse you, biz logic on its associated type). Perhaps I should take the hammer to them yet further? Anyway open to feedback as ever.There are no actual code changes: this is pure cut-paste-use-format. All existing pub exports from the
v2module remain pub exported from thev2module; no new pub exports have been added (at least if they have it's a mistake). I left the tests in the basev2file because they don't get in the way so much.