Use modern Spring LDAP APIs#19408
Open
therepanic wants to merge 1 commit into
Open
Conversation
With the release of spring-ldap 4.1.0, the `LdapClient` API has been updated, so we should update our usage of it. Closes: spring-projectsgh-19407 Signed-off-by: Andrey Litvitski <andrey1010102008@gmail.com>
Contributor
Author
|
I suppose there are no more deprecated usages on this side. |
spring-projects-issues
added
the
status: waiting-for-triage
therepanic
commented
Jul 1, 2026
Comment on lines
-318
to
321
| DirContextOperations result = ldapClient.search().query(query).toEntry(); | ||
| if (result == null) { | ||
| throw new IncorrectResultSizeDataAccessException(1, 0); | ||
| } | ||
| return result; | ||
| return ldapClient.search() | ||
| .query(query) | ||
| .<DirContextOperations>optional() | ||
| .orElseThrow(() -> new IncorrectResultSizeDataAccessException(1, 0)); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
A good case of this is the API update in Spring LDAP.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the release of spring-ldap 4.1.0, the
LdapClientAPI has been updated, so we should update our usage of it. See: spring-projects/spring-ldap#1446Closes: gh-19407