Skip to content

Cast exception code to integer in transaction error - #5

Closed
georgengel wants to merge 1 commit into
spryker:masterfrom
georgengel:patch-1
Closed

Cast exception code to integer in transaction error#5
georgengel wants to merge 1 commit into
spryker:masterfrom
georgengel:patch-1

Conversation

@georgengel

Copy link
Copy Markdown

PDOException uses string values as code. As this is a possible Exception case, the int cast should be included.

PR Description

This is a known issue and solution:
https://www.php.net/manual/en/class.pdoexception.php#95812

Steps before you submit a PR

  • Please add tests for the code you add if it's possible.
  • Please check out our contribution guide: https://docs.spryker.com/docs/dg/dev/code-contribution-guide.html
  • Add a contribution-license-agreement.txt file with the following content:
    I hereby agree to Spryker's Contribution License Agreement in https://github.com/spryker/data-import/blob/HASH_OF_COMMIT_YOU_ARE_BASING_YOUR_BRANCH_FROM_MASTER_BRANCH/CONTRIBUTING.md.

This is a mandatory step to make sure you are aware of the license agreement and agree to it. HASH_OF_COMMIT_YOU_ARE_BASING_YOUR_BRANCH_FROM_MASTER_BRANCH is a hash of the commit you are basing your branch from the master branch. You can take it from commits list of master branch before you submit a PR.

Checklist

  • I agree with the Code Contribution License Agreement in CONTRIBUTING.md

PDOException uses string values. As this is a possible Exception case, the int cast should be included.
@spryker-release-bot

Copy link
Copy Markdown
Collaborator

Dear contributor,

Your pull request will be reviewed by our team. In the meantime, please ensure that the PR complies with Spryker's coding guidelines and that your changes are covered by tests.

Thank you very much for your contribution to the development of Spryker and the growth of the Spryker community!

@spryker-release-bot

Copy link
Copy Markdown
Collaborator

Dear contributor,

the pull request you suggested has been successfully processed and released within the DataImport version: 1.33.1. Thank you very much for your contribution to the development of Spryker and the formation of the Spryker community!
https://github.com/spryker/data-import/releases/tag/1.33.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants