Bug 5553: Segfault when parsing valueless request_header_add - #2482
Open
rousskov wants to merge 1 commit into
Open
Bug 5553: Segfault when parsing valueless request_header_add#2482rousskov wants to merge 1 commit into
rousskov wants to merge 1 commit into
Conversation
request_header_add X-Test-Field-Name Some STL implementations segfault when the `std::string(s)` constructor is given a nil pointer. The exact behavior is undefined by the standard. The constructor API requires a null-terminated (i.e. non-nil) string. Also delayed `nlf` object creation (until it becomes needed) to avoid wasting resources and code lines on an unused object. This code still leaks those objects on `nlf->parse()` failures (i.e. C++ exceptions), but a proper fix for that old bug deserves a dedicated change. The same bug affects the `reply_header_add` configuration directive.
rousskov
commented
Aug 24, 2026
| hwa.valueFormat = nlf; | ||
| } else | ||
| delete nlf; | ||
| // XXX: We leak memory when parse() throws due to a parsing failure. |
Contributor
Author
There was a problem hiding this comment.
This memory leak is an old out-of-scope bug. This PR does not make it worse.
rousskov
added
the
S-could-use-an-approval
kinkie
added
the
backport-to-v7
squid-anubis
pushed a commit
that referenced
this pull request
Aug 26, 2026
request_header_add X-Test-Field-Name Some STL implementations segfault when the `std::string(s)` constructor is given a nil pointer. The exact behavior is undefined by the standard. The constructor API requires a null-terminated (i.e. non-nil) string. Also delayed `nlf` object creation (until it becomes needed) to avoid wasting resources and code lines on an unused object. This code still leaks those objects on `nlf->parse()` failures (i.e. C++ exceptions), but a proper fix for that old bug deserves a dedicated change. The same bug affects the `reply_header_add` configuration directive.
squid-anubis
added
M-waiting-staging-checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some STL implementations segfault when the
std::string(s)constructoris given a nil pointer. The exact behavior is undefined by the standard.
The constructor API requires a null-terminated (i.e. non-nil) string.
Also delayed
nlfobject creation (until it becomes needed) to avoidwasting resources and code lines on an unused object. This code still
leaks those objects on
nlf->parse()failures (i.e. C++ exceptions),but a proper fix for that old bug deserves a dedicated change.
The same bug affects the
reply_header_addconfiguration directive.