-
-
Notifications
You must be signed in to change notification settings - Fork 18
feat: Support floating tag in product image selection #1226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Techassi
wants to merge
9
commits into
main
Choose a base branch
from
feat/product-image-selection-auto-update
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
bba6907
feat: Support autoUpdate in product image selection
Techassi 2dc254d
chore(operator): Fix clippy::collapsible-else-if lint
Techassi e9d1bba
chore(operator): Fix rustfmt error
Techassi 83531c7
refactor: Rename CRD field, improve image selection
Techassi 50ded42
chore(operator): Make clippy happy
Techassi eee5f95
Merge branch 'main' into feat/product-image-selection-auto-update
Techassi c0c9031
refactor(operator): Streamline floating version handling
Techassi f760b36
doc(operator): Update stackableVersion doc comment
Techassi 7a02d0f
chore: Apply suggestion
Techassi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1856,12 +1856,13 @@ spec: | |
| description: Version of the product, e.g. `1.4.1`. | ||
| type: string | ||
| pullPolicy: | ||
| default: Always | ||
| description: '[Pull policy](https://kubernetes.io/docs/concepts/containers/images/#image-pull-policy) used when pulling the image.' | ||
| enum: | ||
| - IfNotPresent | ||
| - Always | ||
| - Never | ||
| - null | ||
| nullable: true | ||
| type: string | ||
| pullSecrets: | ||
| description: '[Image pull secrets](https://kubernetes.io/docs/concepts/containers/images/#specifying-imagepullsecrets-on-a-pod) to pull images from a private registry.' | ||
|
|
@@ -1887,12 +1888,41 @@ spec: | |
| type: string | ||
| stackableVersion: | ||
| description: |- | ||
| Stackable version of the product, e.g. `23.4`, `23.4.1` or `0.0.0-dev`. | ||
| Stackable version of the product, e.g. `26.7.0` or `0.0.0-dev`. | ||
|
|
||
| If not specified, the operator will use its own version, e.g. `23.4.1`. When using a nightly | ||
| If not specified, the operator will use its own version, e.g. `26.7.1`. When using a nightly | ||
| operator or a PR version, it will use the nightly `0.0.0-dev` image. | ||
|
|
||
| If this is used in combination with `useFloatingTag`, the correct floating tag is computed | ||
| automatically, e.g. `26.7.0` becomes `26.7` for the product image. | ||
| nullable: true | ||
| type: string | ||
| useFloatingTag: | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bumping this up so we don't forget
|
||
| default: false | ||
| description: |- | ||
| Use a floating tag for the product image. Defaults to `false`. | ||
|
|
||
| This mechanism utilizes a floating image tag which always refers to the latest patch version | ||
| in the current release line. The current release line is either automatically derived by the | ||
| operator based on its own version, or can be overridden with `stackableVersion`. | ||
|
|
||
| A potential newer image is only pulled when Pods are rotated or their containers are | ||
| restarted. Pods are NOT rotated and containers are NOT restarted automatically when a new | ||
| image is available. This behaviour makes this a passive update mechanism, rather than an | ||
| active one. | ||
|
|
||
| It should be noted that when this field is set to `true`, the operator uses `Always` as the | ||
| pull policy for product images. If set to `false`, `IfNotPresent` is used. Explicitly | ||
| setting `pullPolicy` takes precedence. | ||
|
|
||
| ### Examples | ||
|
|
||
| - The `stackableVersion` field is not set, the operator falls back to its own version, eg. | ||
| 26.7.0. If this field is set to `true`, the `26.7` floating tag will be used for product | ||
| images, else, `26.7.0` will be used. | ||
| - The `stackableVersion` field is set to `26.3.0`. If this field is set to `true`, the | ||
| `26.3` floating tag will be used for product images, else, `26.3.0` will be used. | ||
| type: boolean | ||
| type: object | ||
| secretClassVolume: | ||
| properties: | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.