ROX-35193: remove push-mode code and update CI for pull mode#21436
Draft
vikin91 wants to merge 1 commit into
Draft
ROX-35193: remove push-mode code and update CI for pull mode#21436vikin91 wants to merge 1 commit into
vikin91 wants to merge 1 commit into
Conversation
Delete the old push-mode roxagent packages (index, lock, vsock client, config), the systemd timer, and update CI scripts to deploy roxagent in serve mode and verify the pull flow end-to-end. Update Quadlet units for long-running pull-mode operation. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
This change is part of the following stack: Change managed by git-spice. |
This was referenced Jun 26, 2026
|
Skipping CI for Draft Pull Request. |
Contributor
🚀 Build Images ReadyImages are ready for commit 78d967b. To use with deploy scripts: export MAIN_IMAGE_TAG=4.12.x-327-g78d967bcdf |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## piotr/ROX-35190-roxagent-serve #21436 +/- ##
================================================================
Coverage 50.10% 50.10%
================================================================
Files 2842 2838 -4
Lines 218305 217967 -338
================================================================
- Hits 109374 109208 -166
+ Misses 101002 100837 -165
+ Partials 7929 7922 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two things that go last in the stack:
Push-mode cleanup: Delete the old push-mode roxagent packages (
index/,lock/,vsock/,common/config.go), the systemd timer, and strip push-mode logic fromcmd.go.CI/E2E updates: Deploy roxagent in serve mode and verify the pull flow end-to-end. Update Quadlet units for long-running pull-mode operation.
Deleted packages:
compliance/virtualmachines/roxagent/common/— push configcompliance/virtualmachines/roxagent/index/— push indexer loopcompliance/virtualmachines/roxagent/lock/— single-instance lockcompliance/virtualmachines/roxagent/vsock/— push VSOCK clientscripts/ci/add-vms/systemd/roxagent.timercompliance/virtualmachines/roxagent/quadlet/roxagent.timerUser-facing documentation
Testing and quality
Automated testing
How I validated my change
TODO