Skip to content

Pfam review: 16 owner-classified rows, specificity notes, owner decisions Q6-Q8, R0 status for C. albicans - #73

Merged
hyphaltip merged 16 commits into
mainfrom
pfam-proposals-and-curation-leads
Oct 8, 2026
Merged

hyphaltip merged 16 commits into
mainfrom
pfam-proposals-and-curation-leads

Conversation

@hyphaltip

Copy link
Copy Markdown
Member

What this adds

Follow-up to #72 (merged before these commits were pushed). 15 commits.

  • Owner review of the first Pfam sign-off rows (16 rows): CFEM 7 and Hydrophobin 1 are uncharacterised_true_member, PA14 8 are false_domain_hit. Sheet: docs/reports/data/sorting_hat/specificity/review_sheet_first_signoff.tsv, with PredGPI calls, Af293 ortholog columns, n_tm_mature, and a full Pfam-A scan of the open rows (open10.pfamA_scan.domtbl). Each row's note records the owner's reasoning and caveats.
  • data/sorting_hat/family_table.tsv: three specificity_note edits (CFEM, PA14, Hydrophobin). active is no for all 15 families. Nothing is activated. The change is its own commit (8b1692b). Draft and consequences: docs/reports/2026-10-07-pfam-specificity-notes-draft.md.
  • Owner decisions Q6 to Q8 on per-call status entries recorded in the spec; docs/paper/03 decision 3 corrected (composite calls report a derived status) and docs/paper/04 updated.
  • R0 status source for the C. albicans run (smoke, sensitivity 0.477 [0.356, 0.591]); report and handoff updated.
  • Review-sheet README, ortholog and GPI documentation.

Read before merging

  • Sign-off is not part of this PR. Setting active = yes is the owner's separate change, committed alone, per Plan 2.
  • Only 16 rows are owner-reviewed. The other hits carry classes proposed by pfam_proposals.py from table facts. The member lists are drafts. The notes state counts, not sensitivity or specificity.
  • If CFEM is activated, 29 of 33 hits are called, including C. albicans CSA2 (a secreted heme-binding protein; its helix lies in the signal peptide, so no_tm does not remove it).
  • PredGPI failed on two S288C sequences (TDA8, YHR213W); they are listed as not scored.
  • main differs from this branch only by the merge commit of Pfam proposals, CGD curation leads, owner decisions, per-call status spec (grilling session 2026-10-07) #72.

Package tests: 683 passed, 7 skipped (shellcheck absent). Pre-commit (ruff, ruff-format) passes. No code changed except analysis scripts already in #72.

🤖 Generated with Claude Code

hyphaltip and others added 16 commits October 7, 2026 18:26
… for composite calls

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JXibAde2qW2uRZ4pShs1sW
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JXibAde2qW2uRZ4pShs1sW
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JXibAde2qW2uRZ4pShs1sW
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JXibAde2qW2uRZ4pShs1sW
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JXibAde2qW2uRZ4pShs1sW
…the open rows

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…sheet complete

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…tivated)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…no family activated

Notes follow the owner review of 2026-10-07 (16 rows) and the counts in
docs/reports/2026-10-07-pfam-specificity-notes-draft.md. active stays no for all 15 families.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Owner sign-off 2026-10-07 after the specificity review (8 rows classified, 25 of 29 hits are
glycoside hydrolase or fragment false hits removed by the signal_peptide condition; the 4 hits
that pass are S. cerevisiae FLO1, FLO5, FLO9, FLO10). With PA14 active: S288C 4 hits, Af293 0.
Status stays unvalidated. The shipped-table test now pins the signed-off set.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@hyphaltip
hyphaltip merged commit 9a3202c into main Oct 8, 2026
6 checks passed
@hyphaltip
hyphaltip deleted the pfam-proposals-and-curation-leads branch October 8, 2026 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant