[6.x] Fix Combobox trigger classes not reacting to prop changes - #15133
Merged
Conversation
`triggerClasses` invoked the `cva` factory during setup, so `disabled`, `readOnly`, `variant` and `size` were read once and baked into a static string. Wrapping it in `computed` matches `Input.vue` and `Button.vue`. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where the
Comboboxcomponent's disabled styling wouldn't apply or unapply when thedisabledprop changed after the initial render.This was happening because
triggerClassesinvoked thecvafactory immediately duringsetup, rather than inside acomputed. Thevariant,size,readOnlyanddisabledprops were read once and baked into a static string, so any subsequent change to them was never reflected in the class list.This PR fixes it by wrapping
triggerClassesin acomputed, matching howInput.vueandButton.vuealready build their classes.