Repository navigation
fix(strategy): sandbox sed for regex fields - #43
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A regex field of a package YAML was part of the program of
sed. Atag_version_regexsuch as.*|touch pwned|e;s|(x)|y|;#closed thescommand and added the GNUeflag, andsedrantouchwhilevalidate-pkg.shchecked the field. The same held ingithub-release,github-tag,github-nightlyand for thepatternofwebpage-scrape, so a pull request that changes only a package YAML ran code on the machine that validated it.Every
sedthat takes such a field now runs with--sandbox, which refusese,randw.greptakes the field after-e, so a pattern that starts with a dash is a pattern and not an option.bats tests/ --recursive: 429 pass.