Repository navigation
fix(strategy): limit git-latest to http and https - #58
Merged
Merged
Conversation
validate-pkg.sh requires https:// for upstream.url of type git.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
git-latestclonedupstream.urlof thegittype with every transport git allows from a command line. Afile://URL or a plain path printed the commit count and hash of a repository on the machine that runs the check, and anssh://URL made git runsshto the host in the URL. The clone now runs withGIT_ALLOW_PROTOCOL=http:https, as_git_source_suminlib.shdoes, andvalidate-pkg.shrequireshttps://for that URL, as it does forwebpage-scrape.bats tests/ --recursive: 493 pass. shellcheck, shfmt and actionlint are clean.