Repository navigation
feat(core): name every show by its row id - #79
Merged
Merged
Conversation
Migration 2 lets two shows share a title, as AniList entries do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A show is named by
ShowId, theidof its row inshows, through recognition, the session and the store. A title is what a person is shown, and AniList holds entries that share one: four romaji titles of the five thousand most popular entries belong to two entries each. Filed by title, two such entries merged into one.Corpus::filetakes the show. AMatchcarries it beside the title, and anAmbiguitylistsCandidates that do. The index and the scorer work on shows, and anAssignmentnames one.showswithout the uniqueness of its title, sinceALTER TABLEin SQLite cannot drop a constraint. Migrations run with the foreign keys off and set them back as found: the pragma does nothing inside a transaction, and dropping a table that rows of other tables point at is refused while they are on.Store::new_showfiles a show.record,keep,resumeandclosetake aShowIdand file nothing, and anOperationcarries its show.Over names built from those five thousand entries, 4,425 a form in seven forms, one name a form moved from answered to refused: a spelling that a series and its special share under one title. Every other answer is the same.
cargo test --workspacepasses, 822 tests.