Repository navigation
feat(sync): add ListBackend and its contract suite - #81
Merged
Merged
Conversation
A write carries no score, so the list keeps the account's own.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ListBackendreads an account's list and the entry for one work, and writes where the account stands on a work, adding the work to the list where it is not on it. A write isbenshi_core::list::Write: status, progress and rewatches. It carries no score, so the list keeps the account's own. Every call carries the backend's deadline.benshi_sync::Errorhas six variants:Timeout,Unreachable,Wait,Refused,NoWorkandUnreadable. A message is a reason and names no backend.benshi_sync::memory::Memorykeeps a list and the works off it, and fails in any of five ways on request.tests/contractholds the suite, in the shape of thePlayerWatchersuite.Memorypasses it, andcontract_rejects.rshas a backend for each clause that breaks that clause alone.cargo test --workspacepasses, 868 tests. The suite runs on a paused clock, so a deadline of 15 s costs no real time.