Repository navigation
feat(daemon): keep tokens in the secret store - #84
Merged
Merged
Conversation
A locked store is unlocked only where a call may ask a person.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
benshi_daemon::secretskeeps the token of a backend:Secretsreads, writes and removes it by aKey.Memorykeeps tokens in the process, andSecretService, on Linux, keeps them in the store that answers the Secret Service API on the session bus.application = benshiandbackend = <backend>, passed in aplainsession.Asking::Neverdoes not ask the store to unlock and isError::Locked. A call made withAsking::Withinwaits that long for the person the store asks.DEADLINEis 5 s, andPROMPT_WAIT, the wait for a person, is 2 minutes.zbus5.19.0 is added for Linux, withp2pin the dev-dependencies.The ignored
tests/secret_store_live.rswas run once againstksecretdof kwallet 6.31.0 with the wallet unlocked: the write, read, replace and removal passed and no window was shown. A locked wallet was not tested.cargo test --workspacepasses, 980 tests.