Repository navigation
refactor: spell American in names and text - #87
Merged
Merged
Conversation
AniList's CANCELLED status keeps its spelling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every British spelling under
crates/is American:recognisebecomesrecognize, and so doserialise,normalise,cancelled,behaviour,licenceandspeltwith their forms;noughtbecomeszero.crates/core/src/recognise/moves tocrates/core/src/recognize/, andnormalise.rsin it tonormalize.rs.CANCELLED, a status AniList sends, keeps its spelling.Four lines a person reads change:
benshi whyprintsrecognized:andunrecognized:, the daemon saystask was canceled, andbenshi loginsayslogin canceled. The variants of awhyanswer on the socket are renamed with them, so a client of this version does not read the answer of a daemon started before it.cargo test --workspacepasses, 1070 tests, the same tests as before under their new names.