Repository navigation
test(benshi): read no list where a test counts - #88
Merged
Merged
Conversation
On defaults the list's task adds a line and a bus connection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On default settings the daemon of a binary test also runs the task that reads the AniList list. It says a line and connects to the session bus beside detection, so a test that counts either can count the list's.
a_task_is_told_of.rsread detection's line by its place, and its two tests failed in 4 and 1 runs of 20.a_daemon_nobody_reads_starts_detection_againcounted the list's connection as one of detection's, and passed with detection started again once in place of twice.These tests now run on settings that read the list at no time, from
reading_nothingintests/common/mod.rs.a_task_is_told_ofpassed 60 runs of 60, and the second test fails when detection is started again only once.cargo test --workspacepasses, 1070 tests.