[stefanko-ch]

Summary

destroy-all.yml read the enabled services from D1 before anything else, and stopped when the query failed. A stack that was set up but never deployed has no D1 database, so its destroy could never succeed.

Nexus-Conductor will not delete a user's repository until a destroy succeeds. A never-deployed Conductor user (yara-koch, run 1 on that user's fork) therefore failed at "Generate config.tfvars" and could not be removed.

The fix: when the query fails, the step now asks whether the database exists.

• Absent only if wrangler d1 list --json succeeds and its list does not contain the name. A failed or unparsable listing is still a failure.
• With the database absent, the destroy goes on with no enabled services:
  • tofu destroy acts on the state;
  • the existing init step already skips the destroy when the state bucket is missing too, which is the never-deployed case.

Checks

• The absent-check was run against the real account's D1 list:
  • nexus-yara-koch-nona-company-db reads as absent;
  • nexus-deads8-test-nona-company-db reads as present;
  • garbage input fails jq -e (rc 5) and takes the error path.
• Workflow tests: 105 passed. actionlint is clean.

Local review

CodeRabbit CLI on 1b5d91c5: 0 findings.

Not yet verified

The fix has not run on a real fork; it needs a release first.

How to test

After the release reaches the Conductor template mirror, run destroy for yara-koch (class BIA22) in Conductor. Expect:

1. "D1 database … does not exist" in the log.
2. "R2 credentials not found" or "R2 state bucket not found", then the destroy is skipped.
3. A green run.

Summary by Sourcery

Bug Fixes:

• Allow destroy workflows to proceed for stacks whose D1 database is absent, while still failing safely when the database lookup or account-wide database listing cannot be verified.

[sourcery-ai]

Sorry @stefanko-ch, you've used your own review budget of 250,000 diff characters for the last 7 days.

You can request another review in 5 days and 4 hours by commenting @sourcery-ai review. Upgrade to get a review now.

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: stefanko-ch/Nexus-Stack
• Branch: fix/destroy-without-d1
• File: .coderabbit.yaml
• Commit: 1b5d91c
• Layers: Repository YAML
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: ed81f5bc-80b5-41d3-b5de-5e16aee7f6fd

Commits

Reviewing files that changed from the base of the PR and between 0ed5732 and 1b5d91c.

Files selected for processing: 1

• .github/workflows/destroy-all.yml

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[sourcery-ai]

Reviewer's Guide

The workflow now distinguishes a genuinely absent D1 database from an unavailable or invalid D1 lookup, allowing never-deployed stacks to reach the existing state checks and complete destroy successfully without weakening error handling.

Flow diagram for handling an absent D1 database during destroy

flowchart TD
    A[Read enabled services from D1] --> B{D1 query failed?}
    B -->|No| C[Continue with enabled services]
    B -->|Yes| D[Run wrangler d1 list --json]
    D --> E{Database absent and listing valid?}
    E -->|Yes| F[Set empty enabled services]
    E -->|No| G[Fail destroy]
    F --> H[Run existing state checks]
    C --> H
    H --> I[OpenTofu destroy or skip when state bucket is missing]

Loading

File-Level Changes

Change	Details	Files
Allow destroy workflows to proceed when the stack’s D1 database is confirmed absent.	When the enabled-services query fails, list account D1 databases with Wrangler. Treat the database as absent only when the listing succeeds, parses successfully, and excludes the target name. Use an empty enabled-services result for absent databases; retain the existing failure path for listing or parsing errors. Preserve downstream state-bucket checks so never-deployed stacks are skipped safely.	.github/workflows/destroy-all.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[github-actions]

Coverage report — nexus_deploy

File	Stmts	Miss	Cover	Missing
__init__.py	5	0	100%
_remote.py	42	0	100%
cli.py	4	0	100%
compose_restart.py	40	0	100%
compose_runner.py	102	0	100%
config.py	192	0	100%
firewall.py	206	0	100%
forgejo.py	598	55	90%	783–784, 789, 812–813, 825–826, 862–863, 875–876, 894–895, 920–921, 943–944, 955–956, 1011–1012, 1020–1021, 1026, 1032–1033, 1057–1058, 1091–1092, 1095, 1126–1127, 1168–1169, 1174–1175, 1215–1216, 1247–1248, 1271–1272, 1277–1278, 1377–1378, 1383–1384, 1860, 1864, 1885, 1913–1914, 2001
forgejo_runner.py	47	1	97%	228
hetzner_capacity.py	168	0	100%
hetzner_snapshot.py	202	0	100%
infisical.py	230	0	100%
kestra.py	177	3	98%	227, 441, 802
orchestrator.py	686	77	88%	205, 504–505, 517, 618, 810, 822, 992–993, 998–999, 1031–1033, 1042, 1047–1049, 1060, 1097–1098, 1103–1104, 1124, 1159–1160, 1165–1166, 1174, 1199–1200, 1208, 1279–1280, 1285–1286, 1338–1339, 1344–1345, 1596, 1599, 1669, 1675–1676, 1681–1682, 1716, 1840–1841, 1846–1847, 1896–1897, 1902–1903, 1962, 1977, 2034, 2039–2040, 2045–2046, 2053, 2059, 2234, 2241, 2253–2254, 2259–2260, 2266, 2272, 2356–2357, 2378–2379
pg_preflight.py	191	1	99%	214
pipeline.py	252	13	94%	166–167, 351, 429, 528, 569, 664–665, 710–711, 801–802, 849
r2_tokens.py	113	2	98%	87, 150
s3_persistence.py	299	1	99%	315
s3_restore.py	135	0	100%
secret_sync.py	99	0	100%
seeder.py	98	0	100%
service_env.py	625	33	94%	2504, 2506–2508, 2516–2517, 3111–3114, 3119–3125, 3192–3196, 3212–3216, 3240, 3242, 3264–3265, 3272, 3399
services.py	372	1	99%	3132
setup.py	165	13	92%	245, 315–318, 326, 330–335, 351
ssh.py	52	0	100%
stack_sync.py	96	0	100%
tfvars.py	44	0	100%
tofu.py	86	0	100%
workspace_coords.py	101	0	100%
TOTAL	5427	200	96%

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!