Repository navigation
架构审阅整改批:边界面加固(C2 纪元谓词/C5 评估 rc/C3 门契约单源/C6 tools 分层,伞 #191) - #197
Merged
Merged
Conversation
- test_needs_convert_respects_mtime: 谓词签名 (raw, ptr)→(raw, base) - test_needs_convert_respects_harvest_rev: rebuild 盖章 .rev=HARVEST_REV; 缺失/落后=不匹配→重建自愈;匹配+收敛→跳写(判例:2026-10-10 删改仪式 /2026-10-25 benign② 静默休眠同形) - test_registry_rebuild_ignition_on_rev_drift: _needs_rebuild_of 零 mtime 变化下仅凭版本戳漂移点火/熄火 - test_rev_sidecar_stamp_and_drift_rebuilds: 双族盖章;戳匹配双跳零 harvest; 仅 v4 漂移→仅 v4 重建(v6 不白跑,PEP 289) 4 failed (right reason: HARVEST_REV/rev_path 未实现 / 旧签名恒 True), 32 passed
- _lmdb.py: HARVEST_REV=1 常量(判例:2026-10-10 删改仪式/2026-10-25 benign② 静默休眠同形;bump 纪律入注释);rev_path(base) sidecar; needs_convert(raw, base) 三腿谓词:ptr 缺失 ∨ .rev≠HARVEST_REV ∨ ptr mtime<raw mtime;rebuild_lmdb staged 段盖章(.rev 随 count/cov/ disjoint 提交,ptr LAST 崩溃不变量不动) - _registry._needs_rebuild_of: 比较对象 ptr→族 base(_lmdb_base/ _lmdb6_base),触发车道与 _converged_count 恒一致;_mmdb_path 保留为 scheduler 快照契约(_scheduler.py:169 只读观测) - 基类注释同步(_base/_source_base/ipinfo_lite);infra_services 投影 docstring 加 (f) 段:机制保留,职责正交 - 旧调用点测试换 base 签名(test_infra_services ×4/test_ipinfo_lite ×1) - 红测 4→绿:谓词三腿/注册表点火/双族盖章+单族漂移重建; 修 codec 测试拼接错位(新测试误插在收敛测试场景 A/B 之间,移回尾部) - 存量族无 .rev=不匹配 → 首跑一次全量重建自愈(部署注记见 CHANGELOG)
- test_needs_rebuild_of_detects_stale_mmdb: 场景重写为 ptr+.rev 族 sidecar;补第四腿:.rev 漂移(mtime 收敛)→ 重建 - SchedFakeSource 加 _lmdb_base(幻影环豁免对照组照常:ptr 家族 永不存在 = 恒触发,lmdb_backed=False 豁免不变) - test_registry_valve 假源改族契约属性(谓词本身被 monkeypatch, 断言的是触发车道而非谓词内容) tests/core 725 passed / 8 skipped 全绿
- scripts/c2_predicate_gates.py: 数据面从主仓只读 cp -a 到 worktree backend/data/gate/(gitignored);指纹=sidecar 字节+纪元清单+sha256+mtime_ns - 门①:迁移重建(存量无 .rev → 版本戳腿触发,纪元前进计数不变)后 连续 rebuild 零副作用逐字节同 - 门②:touch 旧仪式 vs HARVEST_REV+1 前进(进程内模拟代码演进,csv mtime 全程不动)——计数相等(1563/56, 123106/0, 32715/0),排除日志 multiset 相等(ziyadnz 46 行),touch 不再必要;rev 前进后收敛无循环 - notes/c2-predicate-ablation-2026-10-25.md: 对照表+迁移注记(41 源 首跑全量重建自愈属预期)
…ain 尾 return rc + 摘要 gate 块 + 报告门裁决节;修复期间行号补丁截断 __main__ 入口的事故(补回)
…dout 接线嵌行(旧无件场景本就绿,不虚构)
…tus(全景行+红腿点名行)/compose_monthly_md leg_status_lines 参数(北星行后,schema-stable 缺省不出)/run_readout 接线嵌入
…t 红外显(重写 F4「其余腿即死」旧契约为 #193 全腿契约)
…(render 前件 readout=null+定稿件),红态行循环点名,结尾聚合腿序首非零退出;check_family -maxdepth 1(修 find 递归让 model/ 子目录同形状件顶替根 all 腿校验的旧洞)+ all 模式排除 leg-status-*;级联桩扩展各腿 *_MODE+写手桩(heredoc python3 - 的 $1='-' 判例)
…放门 rc 机检化入典章机检面;standard-check 47→48 OK)
…ma 实现 + 六面文件单向依赖 DEPS 表。现状 C6-1 绿、C6-2/C6-3 红(拆分未做),绿期=拆分落地
…y,precedents,measurement,discovery}.mjs + 门面(132 行,ToolHost 宿主/注册表/语义门/收口 + prototype mixin 挂载 + 29 名公共 API 面 re-export)。逐字抽取保真:行多重集核对,未保留行仅 14 行计划改写(const→export ×12/AGENT_DIR 上移一层/classifyWebStatus 改直出);零行为变化。t4 54/0(C6-1/2/3 全绿+51 存量零回归);pipeline 60/0;golden 9/0;standard-check 47/0;contract 15/1(env 表待 SRCS 扩至面文件,下一提交)
…入 tools/shared.mjs,双向对拍恢复 16/0;表名注释同步单源口径)②STANDARD.md 四处锚改指面文件(P1→envelope.mjs/P6+门挂点→registry.mjs;标准检锚 47 OK 不降)③selftest.sh node --check 扩面至 tools/*.mjs(标签同步)。门:pipeline 60/0,golden 9/0,t4 54/0,contract 16/0,standard-check 47/0
…派生,禁手抄);run-golden+selftest-pipeline 六处门数/门序断言改 import 单源;新增「注册键序=HEALTH_PIPELINE 执行序」双射不变式测试(61/0);records.length 数字字面量零残留
…HORS 19 员+ANCHOR_ROW_KEYS+anchorRow 构造器,程序化 diff 证双旧副本逐字节一致后合一);run-golden/selftest-pipeline 消费方改 import+零手抄副本(镜像测试钉);§14 哨改单源对拍+新增行键形状哨(C3-4)与折叠族全值域词汇哨(C3-3,ast 抽 _error_family 返回词汇 vs FOLD_GOLDEN 金表末列);node --check 补 anchor-mirror.mjs;pipeline 63/0+golden 9/0+三哨 PASS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
架构审阅整改批:边界面加固(spec #191)
问题
四员架构审阅(/tmp/architecture-review-20261025-ops-agent.html)对运营 agent 六面体检:零 P0、健康度好,但痛点集中在边界面,并经最佳实践对照(notes/ops-agent-best-practices-benchmark-2026-10-25.md,13 个 2026 源)证实三真偏离(spawn env 全量继承违 least-privilege/预算四界缺 3/4/评估轨接线三洞)。本批按用户 grilling 裁定(Q1-Q7)逐票整改。
变更(六票)
验证
整分支(f5d7003,主仓亲跑):backend pytest 全量 2241 passed / 5 skipped / 0 failed(含 e2e 真跑 node+模型 40s);ops selftest.sh 116/0;standard-check 48 OK(条文14/金标3/建议12/挂点30/原语22);C3 篡改四型 T1-T4 红期重放全红实证(merger 独立复演);C6 行为守恒三重验证(导出面 29 名/常量恒等/行多重集零逻辑行变更)。CI 三腿以 PR 首跑为准。
部署注记
Closes #191, closes #192, closes #193, closes #194, closes #195(hotfix #196 已闭)