Repository navigation
Reset detection cache when tokscale binary disappears - #4
Merged
Merged
Conversation
When fetchPeriodStats receives ENOENT from execFile, the tokscale binary was removed after initial detection. Previously this surfaced as a persistent "err" in the sidebar because the cached detection still reported installed=true. Now ENOENT resets the detection cache and throws TokscaleNotFoundError, which tui.tsx catches to transition all periods to "not-installed" — showing the install prompt instead of an opaque error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When tokscale is cached as "installed" but the binary is later removed (or was never fully set up),
fetchPeriodStatsfails with ENOENT. The detection cache still reportsinstalled=true, so the sidebar shows a persistent "err" instead of the install prompt.Fix
tokscale.ts: DetectENOENTinfetchPeriodStatserror handler → callresetDetectionCache()and throwTokscaleNotFoundErrortui.tsx: CatchTokscaleNotFoundError→ setinstalled(false)and transition all periods to"not-installed"stateThis ensures the sidebar falls back to the install prompt (
Install: npm i -g @tokscale/cli) instead of showing an opaque "err".