tidy and consolidate CI - #175
Draft
anish-mudaraddi wants to merge 3 commits into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #175 +/- ##
==========================================
+ Coverage 97.24% 99.14% +1.89%
==========================================
Files 16 32 +16
Lines 1198 1871 +673
==========================================
+ Hits 1165 1855 +690
+ Misses 33 16 -17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
anish-mudaraddi
force-pushed
the
master
branch
3 times, most recently
from
August 18, 2026 18:34
7c55582 to
99f16c9
Compare
setup distinct CI jobs that can be reused. - separate build_image related actions into two distinct CI jobs. Create dev image and Create release image Create dev image runs when a PR is created - to build images and upload them to harbor in the stfc-cloud-staging project. Create release image happens when merged into master we also allow building locally using scripts in .github/scripts/build_dev_image.sh and .github/scripts/build_release_image.sh for local testing See updated readme on how to use the new CI jobs Motivation: - build jobs and CI are complex - there's a lot of repeated code between CI jobs - ultimately performing similar jobs: building dev and release images and uploading to harbor. # Changelog simplified the CI such that: - have 2 scripts to handle building and pushing images - used by github action and can be invoked locally for testing. Easy to test the scripts outside of github actions - created a shared action that builds and pushes a dev image when a PR is opened that changes the contents of a image subdirectory. - created an action that build a new release image when a PR is merged to master - modified existing CI that would regularly publish a PR bumping the patch version for rabbit-consumer docker image. Made this apply to all docker images so that we can force dependencies to updated and the docker build step - simplified individual image CI jobs to just testing and linting - not also building the images. This reduces duplicated code.
anish-mudaraddi
force-pushed
the
master
branch
from
August 18, 2026 19:12
33a35ce to
24cd3ef
Compare
anish-mudaraddi
marked this pull request as draft
August 18, 2026 19:12
rename src package cloudMonitoring to cloudmon to match python naming conventions
anish-mudaraddi
force-pushed
the
master
branch
from
August 18, 2026 19:15
24cd3ef to
7fe0afc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
setup distinct CI jobs that can be reused.
separate image build jobs from testing and linting jobs to promote code reuse.
"Create Dev Image" action runs when a PR is created - to build images and upload them to harbor in the stfc-cloud-staging project.
"Create Release Image" action runs when a PR is merged into master
These actions use scripts in
.github/scripts/build_dev_image.shand.github/scripts/build_release_image.shwhich can be invoked locally for testing purposesSee updated readme on how to use the new CI jobs
Motivation
Build jobs and CI are complex - there's a lot of repeated code between CI jobs - ultimately performing similar build jobs
To make it easier to add new docker images into this repo - "generic" build scripts need to be created to build and push images without explicitly needing to write another CI action.
To add new docker images - we now only need to write an action to test and lint source code - much easier to write and maintain
Changelog
simplified the CI such that:
have 2 scripts to handle building and pushing images - used by github action and can be invoked locally for testing. Easy to test the scripts outside of github actions
created a shared action that builds and pushes a dev image when a PR is opened that changes the contents of a image subdirectory.
created an action that build a new release image when a PR is merged to master
modified existing CI that would regularly publish a PR bumping the patch version for rabbit-consumer docker image. Made this apply to all docker images so that we can force dependencies to updated and the docker build step
simplified individual image CI jobs to just testing and linting - not also building the images. This reduces duplicated code.
Submitter:
Have you done the following?:
major | minor | patchordocumentation | workflowdev-chatops.nubes.rl.ac.ukor staging for this new image for code changes?New / Existing features:
version.txtanddocker-compose.ymlfiles?Have you checked the following?: