DAGE-1226: Move away from Netlify - #1241
Merged
Merged
Conversation
✅ Deploy Preview for stitchdocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR introduces a new GitHub Actions-based deployment path to replace Netlify hosting by building the Jekyll site in CI and deploying either a PR-scoped preview to an S3 prefix (fronted by CloudFront) or a main-site build to the production S3 bucket.
Changes:
- Add a “preview” workflow intended to build a PR preview and publish it to
s3://qlikhelp-stitch-preview/pr-<PR_NUMBER>with a PR comment containing the preview link. - Add a “main” workflow to build the site and sync the build output to the production S3 bucket (plus upload the build as an artifact).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| .github/workflows/build-preview.yml | Adds a manually-triggered PR preview deploy (and intended cleanup) workflow targeting S3/CloudFront. |
| .github/workflows/build-main.yml | Adds a manually-triggered production build-and-sync workflow targeting the main S3 bucket. |
Suppressed comments (3)
.github/workflows/build-preview.yml:72
- The
steps:list items in this job are not indented under thesteps:key, which makes the workflow YAML invalid and the job will fail to load.
steps:
- name: Configure AWS credentials
uses: aws-actions/configure-aws-credentials@e6de054238d6b7531b4efff3b6587d9aade6a06c #v6.2.3
.github/workflows/build-preview.yml:28
- Without a job-level condition, this job will run even when the workflow is invoked for cleanup. Gate it on the
workflow_dispatchaction input so only the intended job runs.
deploy-preview:
# Fork PRs don't get AWS credentials, so skip them explicitly rather than let the job fail
# if: github.event.action != 'closed' && github.event.pull_request.head.repo.full_name == github.repository
runs-on: ubuntu-latest
.github/workflows/build-preview.yml:69
- This job currently runs on every
workflow_dispatchinvocation. Gate it on theworkflow_dispatchaction input so cleanup only runs when explicitly requested.
cleanup-preview:
# if: github.event.action == 'closed' && github.event.pull_request.head.repo.full_name == github.repository
runs-on: ubuntu-latest
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
The hosting costs at Netlify have been bumped and are now extremely high. We need to find a new hosting model for it. This Pull Request adds two new GitHub Actions – one that builds to a new "public" website and one that builds to a "preview" website.
https://qlik-dev.atlassian.net/browse/DAGE-1226
Manual QA steps
The files will probably need to be merged to main before the actions are available to execute. Though, they are both only manually started.
Risks
Low risk to start with, since the actions are manually executed.
Rollback steps
Revert this branch, or just remove the YAML files.