Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Add deterministic diffusion regression coverage and address the noted tutorial corrections.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Release v1.7.2 updates version checking, diffusion handling, tutorials, dependencies, and dataset documentation.
Changes:
- Refresh version-cache behavior.
- Handle empty diffusion runs with warnings.
- Stabilize diffusion tests.
- Expand and correct the introductory tutorial.
- Update release notes and dataset documentation.
File summaries
| File | Description |
|---|---|
tests/testthat/test-zzz.R |
Tests version-cache behavior. |
tests/testthat/test-model_distrib.R |
Makes diffusion testing reproducible. |
R/zzz.R |
Updates version-cache handling. |
R/model_diffusion.R |
Handles empty diffusion runs. |
NEWS.md |
Documents release changes. |
man/mpn_senate112.Rd |
Updates dataset documentation. |
man/mpn_senate.Rd |
Updates dataset documentation. |
man/mpn_elite_usa.Rd |
Updates dataset documentation. |
man/mpn_cow_combined.Rd |
Updates dataset documentation. |
man/mpn_bristol.Rd |
Updates dataset documentation. |
inst/tutorials/tutorial0/tutorial0.Rmd |
Expands and revises the introductory tutorial. |
DESCRIPTION |
Updates package and dependency versions. |
Review details
Files not reviewed (5)
- man/mpn_bristol.Rd: Generated file
- man/mpn_cow_combined.Rd: Generated file
- man/mpn_elite_usa.Rd: Generated file
- man/mpn_senate.Rd: Generated file
- man/mpn_senate112.Rd: Generated file
Suppressed comments (2)
inst/tutorials/tutorial0/tutorial0.Rmd:356
$is not defined for atomic vectors such asages; tryingages$Benerrors. Please reserve$for lists and data frames here and describe[[as the named-vector accessor so beginners are not taught an invalid operation.
The `$` and `[[` operators extract a single named element:
inst/tutorials/tutorial0/tutorial0.Rmd:849
question()andanswer()in this tutorial come from{learnr}, so saying everything except{dplyr}is base R is inaccurate. Qualify this statement to distinguish the tutorial infrastructure and the{dplyr}examples from the base-R code.
Everything in this tutorial (apart from `{dplyr}`) is part of "base" R.
- Files reviewed: 7/12 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #324 +/- ##
==========================================
- Coverage 61.74% 61.51% -0.24%
==========================================
Files 10 10
Lines 732 738 +6
==========================================
+ Hits 452 454 +2
- Misses 280 284 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Package
Models
play_diffusions()so that it drops, with a warning, runs where nothing spreads beyond the seed,instead of stopping with "arguments imply differing number of rows"
test_fit()test so that it does not fail at randomTutorials
[,[[, and$,changing data frames with
mutate()andfilter(), random numbers and seeds,reading errors and writing reproducible examples, and files and projects
{manynet}tutorialsT/Fshorthand, and fixed typos