Skip to content

v1.7.2 - #324

Merged
jhollway merged 7 commits into
mainfrom
develop
Sep 17, 2026
Merged

v1.7.2#324
jhollway merged 7 commits into
mainfrom
develop

Conversation

@jhollway

Copy link
Copy Markdown
Member

Package

  • Fixed the attach-time version check so that it no longer leaves stale messages for up to a week

Models

  • Fixed play_diffusions() so that it drops, with a warning, runs where nothing spreads beyond the seed,
    instead of stopping with "arguments imply differing number of rows"
  • Set a seed in the test_fit() test so that it does not fail at random

Tutorials

  • Updated intro tutorial
    • Added sections on types, missing data, indexing with [, [[, and $,
      changing data frames with mutate() and filter(), random numbers and seeds,
      reading errors and writing reproducible examples, and files and projects
    • Moved packages to a closing "Where next" section that points to the {manynet} tutorials
    • Replaced dead links, removed T/F shorthand, and fixed typos

Copilot AI lite review requested due to automatic review settings September 17, 2026 08:19
@jhollway jhollway self-assigned this Sep 17, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Add deterministic diffusion regression coverage and address the noted tutorial corrections.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Release v1.7.2 updates version checking, diffusion handling, tutorials, dependencies, and dataset documentation.

Changes:

  • Refresh version-cache behavior.
  • Handle empty diffusion runs with warnings.
  • Stabilize diffusion tests.
  • Expand and correct the introductory tutorial.
  • Update release notes and dataset documentation.
File summaries
File Description
tests/testthat/test-zzz.R Tests version-cache behavior.
tests/testthat/test-model_distrib.R Makes diffusion testing reproducible.
R/zzz.R Updates version-cache handling.
R/model_diffusion.R Handles empty diffusion runs.
NEWS.md Documents release changes.
man/mpn_senate112.Rd Updates dataset documentation.
man/mpn_senate.Rd Updates dataset documentation.
man/mpn_elite_usa.Rd Updates dataset documentation.
man/mpn_cow_combined.Rd Updates dataset documentation.
man/mpn_bristol.Rd Updates dataset documentation.
inst/tutorials/tutorial0/tutorial0.Rmd Expands and revises the introductory tutorial.
DESCRIPTION Updates package and dependency versions.
Review details

Files not reviewed (5)

  • man/mpn_bristol.Rd: Generated file
  • man/mpn_cow_combined.Rd: Generated file
  • man/mpn_elite_usa.Rd: Generated file
  • man/mpn_senate.Rd: Generated file
  • man/mpn_senate112.Rd: Generated file

Suppressed comments (2)

inst/tutorials/tutorial0/tutorial0.Rmd:356

  • $ is not defined for atomic vectors such as ages; trying ages$Ben errors. Please reserve $ for lists and data frames here and describe [[ as the named-vector accessor so beginners are not taught an invalid operation.
The `$` and `[[` operators extract a single named element:

inst/tutorials/tutorial0/tutorial0.Rmd:849

  • question() and answer() in this tutorial come from {learnr}, so saying everything except {dplyr} is base R is inaccurate. Qualify this statement to distinguish the tutorial infrastructure and the {dplyr} examples from the base-R code.
Everything in this tutorial (apart from `{dplyr}`) is part of "base" R.
  • Files reviewed: 7/12 changed files
  • Comments generated: 3
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread R/model_diffusion.R
Comment thread inst/tutorials/tutorial0/tutorial0.Rmd Outdated
Comment thread inst/tutorials/tutorial0/tutorial0.Rmd Outdated
@codecov

codecov Bot commented Sep 17, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.51%. Comparing base (9915aec) to head (185c21d).
⚠️ Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
R/model_diffusion.R 60.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #324      +/-   ##
==========================================
- Coverage   61.74%   61.51%   -0.24%     
==========================================
  Files          10       10              
  Lines         732      738       +6     
==========================================
+ Hits          452      454       +2     
- Misses        280      284       +4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jhollway
jhollway merged commit 07e1fa4 into main Sep 17, 2026
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants