CI for coding-styles - #1044
Open
volkm wants to merge 3 commits into
Open
CI for coding-styles#1044volkm wants to merge 3 commits into
volkm wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from #1039
Adds a Python script
resources/scripts/check_style.pywhich allows to check our coding style conventions described indoc/developrs.md. The current version checks:- own header first (bare filename; test files use the
"storm-config.h"+"test/storm_gtest.h"pair instead),- then external (
<...>) includes- then additional (
"...") includes with full path.#pragma once.STORM_LOG_THROW, not a rawthrow./*!, not/**.std::coutmust not be used in the library code.Exceptions are defined in
check-style-ignoreCurrently, the checks
doxygen-styleandstdout-usageyield too many errors and are disabled in the CI.The
include-ordercheck is enabled but needs fixing in a separate PR.