You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
My main reason was that isLess requires a ConstantsComparator. But I agree that it would be more clear to use isLess or even better isLessEqual.
Maybe a more general question: when should we use constants.h and when ConstantsComparator? It seems that both overlap in some functionality.
I agree with your idea to add isLess (without precision) to constants.h. I would simply use the < operator here.
I took a look at ElementLess which we already define and which also uses std::less for comparison. I suggest to remove the double specialization though because it has two issues: a magic number for precision and it only works for non-negative numbers.
I think we haven't used < because the code has to also work for polynomials etc and the intended semantics of the < operator is not clear?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses some parts of #831