Skip to content

test(mcp): qualify Antigravity CLI list results - #728

Merged
polaz merged 4 commits into
mainfrom
test/#716-antigravity-results
Oct 30, 2026
Merged

polaz merged 4 commits into
mainfrom
test/#716-antigravity-results

Conversation

@polaz

@polaz polaz commented Oct 30, 2026 •

Copy link
Copy Markdown
Member

Summary

Qualify GitLab MCP list results through the actual Antigravity CLI without external credentials or model inference. Preserve the existing server output contract for Claude Code and Codex.

Changes

  • Add installed-package qualification with isolated GitLab and scripted Gemini endpoints, verified client archives, and separate wire and client-result evidence.
  • Retain the integrity-checked Gemini CLI Core 0.66.0 transport as a diagnostic baseline. Antigravity 1.4.10 preserves the results that the historical transport invalidates.
  • Document supported clients in the generated GitHub and npm READMEs, plus Antigravity setup, migration, tested behavior and repeatable qualification.

Testing

MCP contract tests and installed-client qualification pass on macOS and Linux with Node.js 24 on Linux. Focused lint, formatting, the documentation build and README generation pass on macOS.

Closes #716

polaz added 2 commits October 30, 2026 00:34
Exercise the installed core package through the actual Antigravity CLI with isolated synthetic GitLab and Gemini endpoints. Compare list, object, native and error results with the integrity-verified historical Gemini transport.

Document client setup, migration and repeatable qualification.

Closes #716
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-30T07:31:18.755953Z 3ef1565 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 28 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
Commits

Reviewing files that changed from the base of the PR and between 801ef5d and 3ef1565.

Files selected for processing: 5
  • README.md
  • packages/gitlab-mcp-db/README.md
  • packages/gitlab-mcp/README.md
  • packages/gitlab-mcp/README.md.in
  • packages/gitlab-mcp/package.json
Walkthrough

Adds Antigravity CLI setup documentation and a qualification harness. The harness runs isolated GitLab MCP scenarios, records client and protocol results, checks current and historical result contracts, and writes a report.

Changes: Antigravity CLI qualification

Layer / File(s) Summary
Qualification contracts and fixtures
packages/gitlab-mcp/scripts/antigravity-contract.mjs, packages/gitlab-mcp/scripts/evaluation-process.mjs, packages/gitlab-mcp/tests/manual/fixtures/*, packages/gitlab-mcp/tests/manual/fixtures/workflow-gitlab.mjs, packages/gitlab-mcp/tests/scripts/antigravity-results.test.mjs, packages/gitlab-mcp/tests/unit/evaluation.test.ts
Adds checks for MCP envelopes, recorded tool calls, client transcripts, and provider responses. Adds fixtures for recording stdio traffic and scripting provider calls, an option for empty merge-request results, and tests for these behaviors and explicit child-process environments.
Qualification execution and reporting
packages/gitlab-mcp/scripts/qualify-antigravity.mjs, packages/gitlab-mcp/package.json
Adds a command that prepares verified client and package artifacts, runs isolated scenarios, checks results, writes a report, and removes temporary runtime files.
Client setup and qualification documentation
packages/gitlab-mcp/docs/clients/antigravity.md, packages/gitlab-mcp/docs/clients/index.md, packages/gitlab-mcp/docs/.vitepress/config.mts
Documents Antigravity CLI setup, migration details, result shapes, and qualification findings. Adds the client guide to the overview and sidebar.

Priority: Normal

Estimated code review effort: 4 (Complex) | ~45 minutes

Change: Other

Sequence Diagram(s)

sequenceDiagram
  participant QualificationScript
  participant AntigravityCLI
  participant ScriptedGemini
  participant MCPEnvelopeRecorder
  participant GitLabMCPServer
  participant WorkflowGitLab
  QualificationScript->>AntigravityCLI: run configured scenario
  AntigravityCLI->>ScriptedGemini: send provider request
  ScriptedGemini-->>AntigravityCLI: return SSE tool call
  AntigravityCLI->>MCPEnvelopeRecorder: send tools/call over stdio
  MCPEnvelopeRecorder->>GitLabMCPServer: forward MCP request
  GitLabMCPServer->>WorkflowGitLab: request merge-request data
  WorkflowGitLab-->>GitLabMCPServer: return fixture data
  GitLabMCPServer-->>MCPEnvelopeRecorder: return MCP result
  MCPEnvelopeRecorder-->>AntigravityCLI: forward MCP result
  AntigravityCLI-->>QualificationScript: complete scenario
  QualificationScript->>QualificationScript: validate recorded calls and results
Loading
Merge Risk: Minimal · previous review 801ef

No demonstrated issue blocks merging. The optional parent-test timeout can be considered separately.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 38.46% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documenta… Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly identifies the main change: qualifying Antigravity CLI list results through MCP tests.
Linked Issues check Passed Issue #716 coding requirements are implemented. qualify-antigravity.mjs installs the packed GitLab MCP artifact, uses loopback GitLab and scripted provider fixtures, isolates client homes, verifies …
Out of Scope Changes check Passed The changes stay within issue #716. The package script, qualification helpers, isolated fixtures, recorder, tests, documentation, and documentation navigation directly support installed-client qualifi…
Full details: Linked Issues check

Explanation

Issue #716 coding requirements are implemented. qualify-antigravity.mjs installs the packed GitLab MCP artifact, uses loopback GitLab and scripted provider fixtures, isolates client homes, verifies archive integrity, and records wire, client, provider, and GitLab evidence. It qualifies empty and single-MR lists through the installed AGY binary, plus object, native structured-result, and error controls. recordedCall and validateEnvelope validate the MCP request and response with the SDK. historicalResult executes the pinned integrity-checked Gemini CLI Core 0.66.0 transport and keeps that result separate from AGY. The qualification checks unchanged list text, empty-list semantics, MR fields, errors, and explicit structured content. The Antigravity documentation records version 1.4.10, migration guidance, historical Gemini behavior, setup, limits, and repeatable execution. The added tests cover fixture behavior, envelope validation, environment isolation, client/provider agreement, and auxiliary provider requests. No REST filters, MR business logic, general result envelope, array structuredContent, speculative schemas, or duplicated list payloads were changed.

Full details: Out of Scope Changes check

Explanation

The changes stay within issue #716. The package script, qualification helpers, isolated fixtures, recorder, tests, documentation, and documentation navigation directly support installed-client qualification, evidence capture, or migration guidance. The existing server result behavior remains unchanged. No unrelated production feature, REST filter, MR business logic, or broad result-shape redesign is included.

Full details: Docstring Coverage

Explanation

Docstring coverage is 38.46% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 13 functions across 9 files. (3 skipped: 3 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Finishing Touches: 💡 1
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Oct 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional comments: 1
packages/gitlab-mcp/tests/unit/evaluation.test.ts-9-12: 1

9-12: Trivial · Stability & Availability · Quick win

Unverified finding
Verification ran but could not confirm this finding. It is shown for review, not as a verified issue.

Add a timeout to spawnSync.

This call now runs two node:test files. antigravity-results.test.mjs starts loopback HTTP servers and uses fetch calls without a timeout. If a fixture server or request hangs, spawnSync blocks the Jest worker with no limit. The whole unit run then stalls instead of failing.

Set a timeout. If the limit is reached, status is null. The existing toMatchObject assertion then fails and prints the partial report.

♻️ Proposed fix
     {
       cwd: resolve(__dirname, '../..'),
       encoding: 'utf8',
+      timeout: 120000,
     },

Review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 0d1921e and 801ef5d.

Files selected for processing: 12
  • packages/gitlab-mcp/docs/.vitepress/config.mts
  • packages/gitlab-mcp/docs/clients/antigravity.md
  • packages/gitlab-mcp/docs/clients/index.md
  • packages/gitlab-mcp/package.json
  • packages/gitlab-mcp/scripts/antigravity-contract.mjs
  • packages/gitlab-mcp/scripts/evaluation-process.mjs
  • packages/gitlab-mcp/scripts/qualify-antigravity.mjs
  • packages/gitlab-mcp/tests/manual/fixtures/mcp-envelope-recorder.mjs
  • packages/gitlab-mcp/tests/manual/fixtures/scripted-gemini.mjs
  • packages/gitlab-mcp/tests/manual/fixtures/workflow-gitlab.mjs
  • packages/gitlab-mcp/tests/scripts/antigravity-results.test.mjs
  • packages/gitlab-mcp/tests/unit/evaluation.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@sonarqubecloud

Copy link
Copy Markdown

@polaz
polaz merged commit 75f9189 into main Oct 30, 2026
19 checks passed
@polaz
polaz deleted the test/#716-antigravity-results branch October 30, 2026 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(mcp): qualify Antigravity CLI list results

1 participant