Skip to content

feat(inventory)!: reconcile hosts and placement - #33

Merged
polaz merged 1 commit into
mainfrom
feat/#30-host-identity
Oct 30, 2026
Merged

polaz merged 1 commit into
mainfrom
feat/#30-host-identity

Conversation

@polaz

@polaz polaz commented Oct 30, 2026

Copy link
Copy Markdown
Member

Summary

  • Reconcile source-qualified hardware, OS, boot and interface evidence through bounded comparisons and atomic, reviewed identity corrections. Preserve independent source mappings, scoped visibility and reversible decisions.
  • Record completed VM migrations through desktop dragging or phone destination selection while preserving the guest and its components. Keep root browsing bounded with visibility applied before exact totals and stable pagination.
  • Validate explicit DNS, mailbox, phone and contact URL values across the persistent API and interface, with shared field permissions, current-only storage and format upgrades. Preserve free labels and opaque provider identities.

Validation

Disk-backed nextest regressions, warning-denied Clippy, alloc-only compilation, Rust/TypeScript interoperability and real-host Chromium desktop/mobile checks. Required CI exercises the full suite and native platform matrix.

Closes #30

Replaces #32.

BREAKING CHANGE: A VM accepts one current RUNS_ON placement; update its existing relation to record another host. Existing ambiguous placements require explicit resolution. Stores upgrade to format 13 and cannot be reopened with older binaries.

Reconcile source-qualified hardware, installation, boot and interface evidence
through scoped comparisons and atomic, reversible identity corrections.
Preserve independent source mappings and current address observations.

Record completed VM migrations through desktop dragging or phone selection,
preserving guest identity and components with conditional placement updates.
Keep root browsing bounded with authorized totals and stable pagination.

Validate explicit DNS, mailbox, phone and contact URL values across storage,
API and interface without changing free labels or opaque provider identities.

Closes #30

BREAKING CHANGE: A VM accepts one current RUNS_ON placement; update its
existing relation to record another host. Existing ambiguous placements
require explicit resolution. Stores upgrade to format 13 and cannot be
reopened with older binaries.
@coderabbitai

coderabbitai Bot commented Oct 30, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 35 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 4d8a54f1-e5d3-4fea-a2e3-0a0e7377188d
Commits

Reviewing files that changed from the base of the PR and between 0fb19a0 and 534089a.

Files ignored due to path filters: 3
  • Cargo.lock is excluded by !**/*.lock
  • web/src/generated/omloom/v1/workspace.ts is excluded by !**/generated/**
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
Files selected for processing: 71
  • .github/workflows/ci.yml
  • crates/omloom-contracts/build.rs
  • crates/omloom-observe/Cargo.toml
  • crates/omloom-observe/src/command/tests.rs
  • crates/omloom-observe/src/main.rs
  • crates/omloom-observe/src/native.rs
  • crates/omloom-observe/src/native/tests.rs
  • crates/omloom-observe/src/runtime.rs
  • crates/omloom-observe/src/runtime/tests.rs
  • crates/omloom-store/Cargo.toml
  • crates/omloom-store/src/disk.rs
  • crates/omloom-store/src/disk/deltas.rs
  • crates/omloom-store/src/disk/inventory.rs
  • crates/omloom-store/src/disk/operations.rs
  • crates/omloom-store/src/disk/tests.rs
  • crates/omloom-store/src/disk/workspace.rs
  • crates/omloom-store/src/disk/workspace/accounts.rs
  • crates/omloom-store/src/disk/workspace/assets.rs
  • crates/omloom-store/src/disk/workspace/correction.rs
  • crates/omloom-store/src/disk/workspace/correction/sources.rs
  • crates/omloom-store/src/disk/workspace/correction/sources/tests.rs
  • crates/omloom-store/src/disk/workspace/correction/undo.rs
  • crates/omloom-store/src/disk/workspace/current_facts.rs
  • crates/omloom-store/src/disk/workspace/definitions.rs
  • crates/omloom-store/src/disk/workspace/exchange.rs
  • crates/omloom-store/src/disk/workspace/host_identity.rs
  • crates/omloom-store/src/disk/workspace/host_import.rs
  • crates/omloom-store/src/disk/workspace/interface_facts.rs
  • crates/omloom-store/src/disk/workspace/network_facts.rs
  • crates/omloom-store/src/disk/workspace/responsibility.rs
  • crates/omloom-store/src/disk/workspace/responsibility/graph.rs
  • crates/omloom-store/src/disk/workspace/software.rs
  • crates/omloom-store/src/disk/workspace/source_layout.rs
  • crates/omloom-store/src/disk/workspace/source_layout/tests.rs
  • crates/omloom-store/src/disk/workspace/typed_values.rs
  • crates/omloom-store/src/disk/workspace/typed_values/tests.rs
  • crates/omloom-store/src/disk/workspace/vm_placement.rs
  • crates/omloom-store/src/disk/workspace/working.rs
  • crates/omloom-store/tests/disk.rs
  • crates/omloom-store/tests/workspace.rs
  • crates/omloom-store/tests/workspace/contexts.rs
  • crates/omloom-store/tests/workspace/correction.rs
  • crates/omloom-store/tests/workspace/correction/continuity.rs
  • crates/omloom-store/tests/workspace/correction/safety.rs
  • crates/omloom-store/tests/workspace/host_import.rs
  • crates/omloom-store/tests/workspace/projections.rs
  • crates/omloom-store/tests/workspace/responsibility.rs
  • crates/omloom-store/tests/workspace/typed_values.rs
  • crates/omloom-store/tests/workspace/vm_placement.rs
  • docs/contracts.md
  • docs/inventory.md
  • docs/storage.md
  • package.json
  • proto/omloom/v1/workspace.proto
  • web/app/AccountPanel.vue
  • web/app/AddressDelta.vue
  • web/app/App.vue
  • web/app/AssetEditor.vue
  • web/app/BulkEditor.vue
  • web/app/CurrentAddresses.vue
  • web/app/FilterEditor.vue
  • web/app/HostIdentityCompare.vue
  • web/app/HostIdentityEvidence.vue
  • web/app/HostImportEditor.vue
  • web/app/HostNetwork.vue
  • web/app/ImportEditor.vue
  • web/app/LocatorInput.vue
  • web/app/ResponsibilityPanel.vue
  • web/app/VmPlacement.vue
  • web/browser/inventory.spec.mjs
  • web/tests/docker-template.test.mjs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-30T13:01:00.170632Z 534089a PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@polaz
polaz merged commit e0b4c41 into main Oct 30, 2026
11 checks passed
@polaz
polaz deleted the feat/#30-host-identity branch October 30, 2026 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: reconcile host identity and placement

1 participant