-
Notifications
You must be signed in to change notification settings - Fork 1
Land the ui v2 component port on js-toolkit v4 #642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
133 commits
Select commit
Hold shift + click to select a range
48789eb
Add the v2 component review as the decision record
titouanmathis 2f3c95f
Switch the workspace to js-toolkit v4
titouanmathis 8d5412f
Port the component families onto js-toolkit v4
titouanmathis 1d2958a
Move the ported specs into the tests package
titouanmathis 336d54a
Port the Slider family onto js-toolkit v4
titouanmathis b5a1e50
Migrate the Disclosure family onto js-toolkit v4
titouanmathis f75793e
Migrate ScrollReveal onto js-toolkit v4
titouanmathis 690e685
Move the workspace to js-toolkit 4.0.0-alpha.1
titouanmathis 441ccf3
Import the real SmoothToRecord type in Cursor
titouanmathis 7860391
Run the test suite in a real browser
titouanmathis d7dff96
Namespace the Disclosure events and restore the default exports
titouanmathis 02e6436
Port LargeText onto js-toolkit v4
titouanmathis 118192c
Remove the internal helpers from the public export surface
titouanmathis 54979e2
Follow the v2 component port in the Reference
titouanmathis 32f655d
Port the Reference stories onto js-toolkit v4
titouanmathis c4961d5
Describe the js-toolkit v4 runtime in the guide and the Reference
titouanmathis 9962d2f
Correct the v3 code samples the twoslash blocks never checked
titouanmathis 9fee34e
Port ui-motion onto js-toolkit v4
titouanmathis d82486a
Port ui-mapbox onto js-toolkit v4
titouanmathis 5727055
Remove the decorators from the ui components
titouanmathis 437fded
Drop the SWC decorator transform from the test setup
titouanmathis c8e430f
Correct the registration guidance in the guide
titouanmathis 0141ee9
Bundle ui-mapbox and ui-motion in the playground again
titouanmathis abcfbb3
Follow the mapbox and motion ports in the documentation
titouanmathis d2819ef
Wait for the children before reading them in the ported components
titouanmathis cbedffe
Stop warning about a map that has simply not mounted yet
titouanmathis 7aae478
Port the mapbox and motion specs onto js-toolkit v4
titouanmathis bd06b0e
Merge branch 'feat/v2-port-mapbox-motion' into feat/v2-component-port
titouanmathis 5817b7c
Update the playground defaults to js-toolkit v4
titouanmathis cabaea3
Move the playground to 0.4.0
titouanmathis 1919363
Rewrite the v1 → v2 migration guide
titouanmathis 2ccc86c
Correct the registration guidance in the Reference
titouanmathis d5d7170
Follow the migrated component sources in the Reference
titouanmathis 41587f7
Follow the mapbox and motion sources in the Reference
titouanmathis becd9d0
Document that Dialog no longer exposes waitUntil
titouanmathis 4c74078
Restore Dialog's waitUntil extension point on emitExtendable()
titouanmathis 5dec493
Wire MotionView back onto the events it claims to listen for
titouanmathis 13f9fe7
Document the restored waitUntil extension point
titouanmathis e649e78
Restore withIndex as the mixin Indexable is built from
titouanmathis d29a5c6
Cover the withIndex mixin form with specs
titouanmathis dc74220
Follow the restored withIndex in the documentation
titouanmathis dbf714d
Record the withIndex resolution in the v2 review
titouanmathis c5e7cde
Reduce the v1 to v2 migration guide to facts and steps
titouanmathis b06f531
Rewrite Tabs onto js-toolkit v4 and the WAI-ARIA tabs pattern
titouanmathis 4c9ed58
Cover the rewritten Tabs with specs
titouanmathis 6672ae6
Follow the Tabs rewrite in the Reference
titouanmathis e5355dd
Record the Tabs rewrite in the migration guide and the v2 review
titouanmathis fb79e4a
Merge branch 'feat/v2-rewrite-tabs' into feat/v2-component-port
titouanmathis 5333064
Redefine the Slider rewrite as a transport consolidation
titouanmathis 7edbbdd
Fix Fetch dropping repeated form fields and leaking src into history
titouanmathis 5d6dee6
Implement the accessibility contract on the Carousel family
titouanmathis 7bf292f
Cover the Carousel accessibility contract with specs
titouanmathis 67ad592
Document the Carousel accessibility contract
titouanmathis 7f64b3c
Merge branch 'feat/v2-carousel-a11y' into feat/v2-component-port
titouanmathis 83db960
Drop the playground patch that 0.4.0 made obsolete
titouanmathis cd8b8b9
Clamp a flicked carousel drag to one snap and restore snapping
titouanmathis 859f29b
Add CarouselPlay, the carousel rotation control
titouanmathis f9e4b24
Document the drag settle and the CarouselPlay control
titouanmathis e88d70d
Get CI past install and green
titouanmathis a6f0780
Merge pull request #643 from studiometa/fix/fetch-multi-value-and-his…
titouanmathis 4f2e0bd
Add 1.11.0 changelog entry
titouanmathis f6147c5
Prepare 1.11.0
titouanmathis e7025f5
Merge pull request #645 from studiometa/chore/prepare-1.11.0
titouanmathis 3f85478
Widen the Track throttle window so a slow runner cannot cross it
titouanmathis 2b8c699
Merge branch 'feat/v2-carousel-drag-autoplay' into feat/v2-component-…
titouanmathis 99792e5
Register CarouselPlay as a Carousel child
titouanmathis f9f7ae4
Fix Fetch keeping src in history on a click or a submit
titouanmathis 0c6baeb
Merge pull request #646 from studiometa/fix/fetch-history-declarative
titouanmathis 06e3525
Add 1.11.1 changelog entry
titouanmathis d1be85b
Prepare 1.11.1
titouanmathis 5720cd2
Merge pull request #647 from studiometa/chore/prepare-1.11.1
titouanmathis 8e056a7
Bring the migration guide up to the current round
titouanmathis 60bc443
Make the last two CI-only failures speed-independent
titouanmathis 76b7f83
Remove the Slider family from the ui package
titouanmathis 7d69503
Remove the Slider specs and drop its names from the export snapshots
titouanmathis 1fc3985
Remove the Slider reference docs and repoint what named it
titouanmathis 4dd343c
Attach the progress recorder before the countdown arms
titouanmathis d799b0d
Write the Slider to Carousel migration path
titouanmathis 7ab1e45
Record the Slider drop in the component inventory
titouanmathis 0a013fb
Publish the carousel scroll progress on its context
titouanmathis 8a5ec6c
Add the four Carousel controls
titouanmathis 8e13400
Export the four Carousel controls from the package and the reference
titouanmathis d121641
Cover the four Carousel controls with specs
titouanmathis 47f7301
Document the four Carousel controls
titouanmathis d1ebaca
Merge branch 'feat/v2-carousel-controls' into feat/v2-component-port
titouanmathis 850a026
Merge branch 'feat/v2-remove-slider' into feat/v2-component-port
titouanmathis 166e1ed
docs: record round 8 and fix the CarouselPlay registration claim
titouanmathis 1dee2cb
fix(carousel): hold the index through a programmatic scroll
titouanmathis 71e852b
feat(carousel): read the scroll alignment from the slide's CSS, keep …
titouanmathis 89442f9
feat(carousel): let the track's scroll-snap-type decide whether a dro…
titouanmathis f32774a
docs(carousel): add alignment and free-scroll examples
titouanmathis 0e8c6d5
fix(carousel): carry the pointer's velocity into the drag settle
titouanmathis 3d89de3
refactor(ui): one marker for a picker, one source for the lint list
titouanmathis e6125c3
fix(docs): make js twoslash blocks actually type-check
titouanmathis ce7c302
fix(lint): quote the prettier glob so it checks every doc
titouanmathis 243f8a3
style(docs): format the 10 markdown files the glob had never reached
titouanmathis a9a2a8e
chore(ui): drop the unused alien-signals dependency
titouanmathis 419e568
docs(api): replace dropped Accordion in PHP examples with Disclosure
titouanmathis 0f17cef
perf(ui): import js-toolkit symbols from their subpaths
titouanmathis 41680f2
fix(docs): point the v1 reference redirects at their v2 destinations
titouanmathis 57d25d9
chore(ui): drop the three remaining unused runtime dependencies
titouanmathis d3b6cd0
Merge remote-tracking branch 'origin/fix/v2-twoslash-typecheck' into …
titouanmathis d3ce704
Merge remote-tracking branch 'origin/fix/v2-prettier-glob' into feat/…
titouanmathis 8a54507
Merge remote-tracking branch 'origin/chore/v2-twig-extension' into fe…
titouanmathis 1835aad
Merge remote-tracking branch 'origin/chore/v2-drop-alien-signals' int…
titouanmathis c5a37c6
Merge remote-tracking branch 'origin/perf/v2-subpath-imports' into fe…
titouanmathis 1acb59d
chore: finish the v2 sweep the PHP-side audit left behind
titouanmathis 829b0e4
Merge remote-tracking branch 'origin/chore/v2-twig-extension' into fe…
titouanmathis c7fd36a
fix(docs): redirect the renamed and dropped items on the current pref…
titouanmathis c30e3d3
fix(api): remove the dead /source endpoint and its path traversal
titouanmathis e00eb38
Merge remote-tracking branch 'origin/fix/api-source-path-traversal' i…
titouanmathis 1f103c0
chore: drop the stale dependency references the v2 removal left behind
titouanmathis 300df9a
Merge remote-tracking branch 'origin/chore/v2-stale-peer-lists' into …
titouanmathis 982b3e1
feat(ui)!: redesign Cursor around published CSS hooks
titouanmathis 4f9d7a3
Merge remote-tracking branch 'origin/feat/v2-cursor-redesign' into fe…
titouanmathis fcb834c
feat(ui): merge LargeText and CircularMarquee into one generic Marquee
titouanmathis febaebc
Merge remote-tracking branch 'origin/feat/v2-marquee' into feat/v2-co…
titouanmathis 73a032b
docs: correct the round 9 and 10 test counts for the merged tree
titouanmathis 0abc61b
docs(ui-motion,ui-mapbox): describe the code instead of the port
titouanmathis fbddf06
docs(ui-motion,ui-mapbox): point the injectors at the real setup API
titouanmathis bee2d36
Merge remote-tracking branch 'origin/chore/v2-comments-packages' into…
titouanmathis 8551a83
docs(tests): describe what the specs assert, not what changed
titouanmathis 013d35c
Merge remote-tracking branch 'origin/chore/v2-comments-tests' into fe…
titouanmathis 5d6c331
test: drop the version comparison from three test names
titouanmathis 94900eb
docs(tests): drop comparisons that name no version
titouanmathis c00e35c
Merge remote-tracking branch 'origin/chore/v2-comments-tests' into fe…
titouanmathis 63098cf
docs(ui): describe the code as it is, not as a port
titouanmathis c57d573
Merge remote-tracking branch 'origin/chore/v2-comments-ui' into feat/…
titouanmathis c536334
fix(fetch): keep repeated GET form fields and keep `src` out of history
titouanmathis dbd5b6c
Merge remote-tracking branch 'origin/chore/v2-merge-main' into feat/v…
titouanmathis 341371d
docs(changelog): add the 2.0.0-alpha.0 section
titouanmathis 18ab0ad
Merge remote-tracking branch 'origin/chore/v2-changelog' into feat/v2…
titouanmathis 2d5253b
chore: prepare 2.0.0-alpha.0
titouanmathis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: README still registers removed components
The example imports
FrameandScrollAnimation, but this change removes both exported families. Following the documented setup therefore produces unresolved imports; replace them with components that remain in the v2 surface.Confidence: high.
Reviewed by @weareikko/code-review v0.9.5 for commit f32774a.