[gateway] wildcard hostnames will use "wildcard" instead of "*" for the listener name#290
Merged
DanielRaapDev merged 8 commits intoJul 3, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the gateway Helm chart to support custom names for HTTPS listeners, enabling users to avoid generating invalid listener/certificate reference names from certain hostnames (e.g., wildcard hosts).
Changes:
- Add support for
gateway.https[].nameto drive generated HTTPS listener names. - Update chart tests/fixture values to cover a wildcard host with a custom name.
- Bump chart version and update Artifact Hub changelog annotation.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| charts/gateway/templates/gateway.yaml | Use optional gateway.https[].name when constructing HTTPS listener name and default cert-manager secret reference name |
| charts/gateway/tests/values/full.yaml | Add a wildcard HTTPS host test value using the new name field |
| charts/gateway/tests/gateway_test.yaml | Add assertions for the newly rendered wildcard HTTPS listener and its certificateRef name |
| charts/gateway/Chart.yaml | Bump chart version and update Artifact Hub “changes” annotation |
Co-authored-by: Daniel Raap <raap@subshell.com>
DanielRaapDev
changed the title
DanielRaapDev
changed the title
DanielRaapDev
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TSTCLD-108