🐛(frontend) hide the selection highlight on presenter images - #2665
Conversation
8bd9ae6 to
5187bfe
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. WalkthroughThe presenter view now hides BlockNote selection overlays on selected block and inline content. The presenter-mode end-to-end test checks that the overlay content is Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to Presenter slides and exported slides no longer show image selection chrome, while normal editor selection styling remains unchanged. No current merge-blocking risk remains. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Size Change: 0 B Total Size: 5.94 MB 📦 View Changed
|
Presenter reset no longer hid selection; image slides appeared focused on open.
5187bfe to
bcc1eb9
Compare
Purpose
Opening presenter mode paints a blue frame and tint on a slide that starts
with an image, which reads as keyboard focus even though nothing is focused.
It is BlockNote's node selection: it is drawn as an
::afteroverlay, and the presenter only reset
outline. The same component rendersthe PDF export, so the halo was also printed into exported slides.
Reported as "focus is put on image of the presentation with no reason".
The actual focus handling in presenter mode is a separate change that is handle in this PR.
BEFORE :
presentermodeoverlaybefore.mp4
AFTER :
presentermodeoverlayafter.mp4
Proposal
::afterselection overlay in presenter slidesoutline