Skip to content

🐛(frontend) hide the selection highlight on presenter images - #2665

Merged
Ovgodd merged 1 commit into
mainfrom
fix/presenter-hide-block-selection
Sep 9, 2026
Merged

Ovgodd merged 1 commit into
mainfrom
fix/presenter-hide-block-selection

Conversation

@Ovgodd

@Ovgodd Ovgodd commented Sep 9, 2026 •

Copy link
Copy Markdown
Collaborator

Purpose

Opening presenter mode paints a blue frame and tint on a slide that starts
with an image, which reads as keyboard focus even though nothing is focused.

It is BlockNote's node selection: it is drawn as an ::after
overlay, and the presenter only reset outline. The same component renders
the PDF export, so the halo was also printed into exported slides.

Reported as "focus is put on image of the presentation with no reason".
The actual focus handling in presenter mode is a separate change that is handle in this PR.

BEFORE :

presentermodeoverlaybefore.mp4

AFTER :

presentermodeoverlayafter.mp4

Proposal

  • Hide BlockNote's ::after selection overlay in presenter slides
  • Extend the existing e2e test to assert on the overlay, not just outline
  • no regression: images stay selectable (blue chrome) outside presenter mode

@Ovgodd
Ovgodd force-pushed the fix/presenter-hide-block-selection branch from 8bd9ae6 to 5187bfe Compare September 9, 2026 10:58
@Ovgodd Ovgodd linked an issue Sep 9, 2026 that may be closed by this pull request
@Ovgodd
Ovgodd requested a review from AntoLC September 9, 2026 11:01
@Ovgodd Ovgodd self-assigned this Sep 9, 2026
@Ovgodd Ovgodd added bug Something isn't working accessibility triage labels Sep 9, 2026
@Ovgodd Ovgodd moved this to In Progress in LaSuite Docs Sep 9, 2026
@Ovgodd
Ovgodd marked this pull request as ready for review September 9, 2026 11:01
@coderabbitai

coderabbitai Bot commented Sep 9, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 6d9bd4e0-b682-4f60-9b5d-879de5466cf5

📥 Commits

Reviewing files that changed from the base of the PR and between 64b23e8 and 5187bfe.

📒 Files selected for processing (3)
  • CHANGELOG.md
  • src/frontend/apps/e2e/__tests__/app-impress/presenter-mode.spec.ts
  • src/frontend/apps/impress/src/features/docs/doc-presenter/components/PresenterSlideContent.tsx

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


Walkthrough

The presenter view now hides BlockNote selection overlays on selected block and inline content. The presenter-mode end-to-end test checks that the overlay content is none and that the outline remains disabled. The changelog documents the fix and removes trailing whitespace from an existing entry.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to bcc1e

Presenter slides and exported slides no longer show image selection chrome, while normal editor selection styling remains unchanged. No current merge-blocking risk remains.

Suggested reviewers: panchoutnathan

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: hiding the selection highlight on presenter images. It is concise and related to the changeset.
Description check ✅ Passed The description accurately explains the BlockNote selection overlay, the presenter and PDF impact, the test update, and the separate focus-handling change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/presenter-hide-block-selection

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 9, 2026 •

Copy link
Copy Markdown
Contributor

Size Change: 0 B

Total Size: 5.94 MB

📦 View Changed
Filename Size Change
apps/impress/out/_next/static/75f9f6d4/_buildManifest.js 0 B -721 B (removed) 🏆
apps/impress/out/_next/static/27022d83/_buildManifest.js 721 B +721 B (new file) 🆕

compressed-size-action

Presenter reset no longer hid selection; image slides appeared focused on open.
@Ovgodd
Ovgodd force-pushed the fix/presenter-hide-block-selection branch from 5187bfe to bcc1eb9 Compare September 9, 2026 13:10
@Ovgodd
Ovgodd merged commit bcc1eb9 into main Sep 9, 2026
50 of 51 checks passed
@Ovgodd
Ovgodd deleted the fix/presenter-hide-block-selection branch September 9, 2026 14:12
@github-project-automation github-project-automation Bot moved this from In Progress to Done in LaSuite Docs Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accessibility bug Something isn't working triage

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Focus on image in presenter mode

2 participants