Conversation
Some APIs only accept credentials in the URL query string (e.g. NetActuate's vapi2 rejects Authorization and X-API-Key headers). Extend the dst config/param with a "query:<param>" form that sets the secret as a query parameter on the request URL, preserving existing parameters. Header and query dsts are separate namespaces: a sealed or allowlisted header dst never authorizes a query destination of the same name, and vice versa. Query parameter names are matched case sensitively, without the MIME header canonicalization applied to header dsts. Prior art: sprites-api's Connectors gateway supports the same query_param injection method alongside header injection.
url.Values.Set only replaces an exact-case duplicate, so a request carrying ?KEY=evil would survive alongside the injected ?key=<secret>, a parameter-pollution vector against upstreams that match parameter names loosely. Strip any case-insensitive match for the destination param before setting the injected value.
timflyio
approved these changes
Jul 15, 2026
timflyio
left a comment
timflyio
left a comment
Contributor
There was a problem hiding this comment.
looks good to me. my only comment is that we could have added a new field to the DstProcessor spec instead of using the "query:" prefix in the Dst field. I'm not sure how I feel about it though... it feels "cleaner" in the code, but clunkier to use in practice...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.