Move the major tag automatically on release - #13
Open
scottf wants to merge 3 commits into
Open
Conversation
Callers use @v2, which only delivers fixes if the tag is repointed at every release. That was done by hand and got missed: v2 stayed on the pre-#12 commit for two days after the fix merged, so consumers kept running the broken auto-review gate with no signal anything was stale. Pushing a vX.Y.Z tag now force-moves vX to the same commit. Pre-release tags are ignored.
A filter that never matches would make this workflow silently do nothing -- the same quiet staleness it exists to prevent. [0-9]* needs only plain glob semantics, and still requires a digit in each position.
The Releasing section covered the routine case but not a new major, leaving a reader to assume they seed v3 themselves. Pushing v3.0.0 creates v3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Callers reference this repo as
@v2— a moving tag. That only delivers fixes if someone repoints the tag at every release, and that step is manual.It got missed. PR #12 (fix for auto-review skipping maintainer PRs) merged on July 20, but
v2stayed on5b7104f, the commit that introduced the bug.nats-io/nats.javaresolves@v2, so it kept running the broken gate — a brand new PR two days later (#1601) was still skipped. Nothing surfaced this; the run just showedskippedand the caller had no way to tell it was on a stale version.I've since moved
v2tod24bb93and cutv2.3.1, so that specific problem is fixed. This PR is so it can't happen again.What
.github/workflows/move-major-tag.yml— pushing avX.Y.Ztag force-movesvXto the same commit.Pre-release tags (
v2.4.0-rc1) are skipped, so they don't movev2.Needs
contents: writeto push the tag; that's scoped to this one job. README gains a short "Releasing" subsection under Versioning.Note
Tags pushed by
GITHUB_TOKENdon't trigger workflows, so there's no recursion risk here — and the trigger pattern requires two dots, whichv2doesn't have, so it wouldn't re-fire anyway.