chore: migrate to OroCommerce 7.0 / Symfony 7 / PHP 8.5 - #37
Merged
Merged
Conversation
Routing\Annotation\Route (Doctrine annotations namespace) migrated to
Routing\Attribute\Route (native PHP attributes), required since Symfony 7
removed the annotation loader.
InlineClassRoutePrefixRector (detected by oro/upgrade-toolkit oro-70 set):
the class-level #[Route('/ajax')] prefix on FavoriteButtonAjaxController
must be inlined into each method route to comply with Symfony 7 conventions.
Dead code removed in FavoriteDatagridListener: $repo was assigned but never
read — $favoriteRepo performed the same lookup two lines below.
Dev dependencies updated for Symfony 7 / PHP 8.5 compatibility:
- grumphp ^1.5 → ^2.10 (symfony/yaml ~5.x||~6.x conflict with Oro 7.0)
- phpspec dropped (no specs exist; package does not support PHP 8.5)
- phpstan ^1.5 → ^2.0
- php-cs-fixer ~3.57.2 → ^3.57 (3.57.x does not support PHP 8.5)
- .php-cs-fixer.cache added to .gitignore
phpstan 2.x parses @SuppressWarnings(PHPMD.*) as PHPDoc and rejects it;
suppressed via phpDoc.parseError identifier in phpstan.neon since these
annotations are PHPMD-only and cannot be changed without breaking PHPMD.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Routing\Attribute\Route)InlineClassRoutePrefixRector: class-level#[Route('/ajax')]prefix inlined into method routes (detected byoro/upgrade-toolkitoro-70 set)FavoriteDatagridListener(\$reponever read)^2.10, phpstan^2.0, php-cs-fixer^3.57, phpspec dropped@SuppressWarningsPHPMD annotations suppressed viaphpDoc.parseErroridentifier).php-cs-fixer.cacheadded to.gitignoreTest plan
oro/upgrade-toolkitoro-70 Rector set — no remaining BC breaks