fix: require accepted onchain broadcasts - #1225
Draft
ovitrif wants to merge 4 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1211
This PR updates Android's on-chain send consumer to the final unpublished LDK rc.67 artifact and preserves the distinction between accepted, terminally rejected, and uncertain broadcast outcomes.
Description
com.synonym:ldk-node-android:0.7.0-rc.67from Maven Local for validation of LDK Improve Wallet and LDK node business logic handling #113 atop Implement tag feature in the EditInvoiceScreen #115.Txidreturn.NodeExceptionconstructors.Preview
2026-09-05-android1225-accepted.mp4
2026-09-05-android1225-rejected.mp4
QA Notes
Manual Tests
23a1ef7f277a777a7be6b2ab1b40c54e2e3e88f8d34e54a4d2b9ccd3a8bc3528entered the mempool; the success UI and sent activity showed it.-26 non-finalforbbd23b0a9de52acb61ef55d3e1ea4f14f98a964932e93c255a8ee26756f6f191, which returnedOnchainTxBroadcastRejected; success UI and a second sent activity were absent, and the mempool was unchanged. This proves Android's handling of a terminal Electrum rejection; it is not a live backend policy-rejection test.Automated Checks
LightningRepoTest.kt: covers accepted and non-accepted on-chain sends, includingOnchainTxBroadcastNotDispatched.AppViewModelSendFlowTest.kt: verifies a rejected on-chain send does not present success.PaymentFailureReasonExtTest.kt,QuickPayRepoTest.kt, andLightningServiceTest.kt: compile against final generated rc.67 error bindings.just compile,just test, andjust lintpassed using Maven Local rc.67; Detekt reports only existing baseline findings outside this PR.E2E=true E2E_LOCAL_HOST=10.0.2.2 ./gradlew assembleDevDebuginstalled the reviewed head on a fresh Android emulator. The app was restored to the shared fixture after the rejection check.Dependency
Blocked from merge until the unpublished
com.synonym:ldk-node-android:0.7.0-rc.67artifact from ldk-node#113, stacked on #115, is published to the repository CI can resolve. No release is included here.