fix: add android r8 rules - #106
Merged
Merged
Conversation
Package targeted UniFFI 0.28 / JNA consumer keep rules into the ldk-node-android AAR as proguard.txt, and fail bundleReleaseAar when those rules are missing or empty.
This was referenced Aug 26, 2026
ovitrif
marked this pull request as ready for review
August 26, 2026 17:06
ovitrif
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #105
The Android AAR now ships targeted R8 consumer keep rules for the UniFFI 0.28 / JNA FFI surface.
These rules are packaged as
proguard.txtand apply automatically when a consuming app enables R8.Description
bindings/kotlin/ldk-node-android/lib/consumer-rules.prointo the AAR asproguard.txt.org.lightningdevkit.ldknode:Structurefields and constructorsCallbackmethodsUniffiLibinterface method names used byNative.loadbundleReleaseAarwhen those consumer keep rules are missing or empty.Preview
N/A — Android library packaging only.
QA Notes
Local verification:
./gradlew :lib:validateConsumerKeepRules :lib:bundleReleaseAarfrombindings/kotlin/ldk-node-android, then confirmedproguard.txtinside the release AAR.Keep rules follow synonymdev/bitkit-core#139 for this crate's UniFFI 0.28
Native.loadsurface.