Preserve comments between patch value colon and value - #49
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
Prepared with Codex assistance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #41.
Value.Patchdrops comments between the"value":colon and the value. For example,"value": /* explanation */ 42loses the explanation even though comments preceding the"value"member are retained.Preserve those value-adjacent comments alongside the member's leading comments, retaining their order. Whitespace-only extras follow the existing behavior. This affects both add and replace operations without changing the patched JSON value.
Ten regression cases cover block and line comments when adding to arrays, objects and the document root, and replacing array/object entries. All ten fail before the fix; they verify both comments survive formatting and the resulting JSON is correct.
Validation:
go test ./... -count=1andgo vet ./...pass.go test -race ./... -count=1passes.gofmtandgit diff --checkpass.Prepared and tested with Codex assistance.