hujson: fix Patch test operation for null values - #51
Closed
RaphaelFakhri wants to merge 1 commit into
Closed
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
equalValue treated a decoded JSON null as a failed unmarshal, so a "test" operation against a null value always reported a difference. Track unmarshal success separately from the decoded value. Fixes #50 Signed-off-by: Raphael Fakhri <153192858+RaphaelFakhri@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
testoperation ofValue.Patchalways failed for anullvalue.equalValueused a nil interface both for a decoded JSONnulland for an unmarshal error, so two nulls never compared equal.This change tracks unmarshal success separately from the decoded value.
Testing
Two cases are added to
TestPatch: atestofnullagainstnullsucceeds, and atestof0againstnullstill fails.Before the change, one subtest fails. After the change, all 59 subtests pass.
Fixes #50