hujson: reject Patch add operations with an out-of-range array index - #53
Closed
RaphaelFakhri wants to merge 1 commit into
Closed
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
RFC 6902, section 4.1 requires the index of an "add" operation on an array to be no greater than the array length. Patch instead silently appended the value for any larger index. Return an error instead. Fixes #52 Signed-off-by: Raphael Fakhri <153192858+RaphaelFakhri@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Value.Patchsilently appended the value for anaddoperation whose array index was greater than the array length. RFC 6902, section 4.1 requires an error in that case.patchAddnow returns an error when the index is neither-nor exactly the array length. Indexes of existing elements and the append cases are unchanged.Testing
Three cases are added to
TestPatch: index equal to the length appends,-appends, and index5on a two-element array returns an error and leaves the array unchanged.Before the change, one subtest fails. After the change, all 60 subtests pass.
Fixes #52