M8: distribution, default SoundFont, sfizz hardening, review fixes, exile v2#2
Merged
Conversation
…iew fixes
- scorekit doctor, release/pages workflows, Makefile install targets, mdBook site
- Default MuseScore General resolution for render/build/batch (SCOREKIT_SOUND_LIBRARY_DIR)
- sfizz renderer profiles, profile check, checksum-pinned soundfont fetch script
- Review follow-ups:
- Clarify the no-DSP iron rule: creative DSP stays banned; deterministic
sample-exact PCM assembly (audio.rs) is explicitly in scope
- build_sfizz.sh: clean up .part artifact on failure
- require_backend returns a Backend enum; build_one matches on it (no expects)
- E2E: build/batch default-soundfont happy + failure paths; acceptance matrix updated
- make test-install exercises fetch_default_soundfont.sh over file:// incl.
checksum-failure recovery
- exile-in-the-dunes v2 worked example (rebalanced 96-beat exile_arc) + guard test
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
M8 milestone work plus the follow-ups from this session's two-axis project review.
M8 distribution & defaults
scorekit doctor, release/pages workflows,Makefileinstall targets, English mdBook siteSCOREKIT_SOUND_LIBRARY_DIR) forrender/build/batchprofile check, checksum-pinned SoundFont fetch scriptReview follow-ups
src/audio.rs) is explicitly in scope — it upholds bit-exact invariants ("sum of stems == full mix", seamless-loop seal) that external filter pipelines cannot guaranteebuild_sfizz.sh:.partartifact cleaned up on failure (no partial binary residue)require_backendnow returns aBackendenum;build_onematches on it, removing both action-at-a-distance.expect()sbuild/batchdefault-soundfont happy paths +batchstructured failure before any write; acceptance matrix updatedmake test-installexercisesfetch_default_soundfont.shfor real overfile://sources, including checksum-failure recovery with no.partresidueexile-in-the-dunes v2
exile_arc: tonic D before the rupture deleted (high D–C–A–G…F–E breaks directly), first rest shortened 8→6, freed beats redistributed (overreach 4→6, break-note E 2→4, rupture silence 8→12 landing on bar 17), total length and final unresolved E unchangedValidation
cargo fmt --check/cargo clippy --all-targets -- -D warnings/cargo test(80 tests) all greenmake test-installgreen end-to-end